Strange colors with rl-deconvolution

[Beep6581]

Originally reported on Google Code with ID 1430

Currently i'm using Raw Therapee 4.0.8.1 with Ubuntu 10.04 (64bit) (i haven't yet seen
a 4.0.9 package for this distro), and i have found that the output file differs quite
a lot from what i see in the preview window, and i don't understand what i'm doing
wrong. I have choosed srgb as working color space and as output.

I attach the raw (Pentax K20 pef), the pp3, the jpg output and a screenshot with the
preview and the result @ http://ubuntuone.com/4zp0Ws0rJAyd7S1KNSLq7v

Thanks to DrSlony (via forum) i have tried without rl deconvolution and the problem
disappears (also with rl on, the image isn't "sharper" than without.

Branch: default
Version: 4.0.8.1
Changeset: 08422f013749
Compiler: GCC 4.4.3
Processor: undefined
System: Linux
Bit depth: 64 bits
Gtkmm: V2.20.3
Build type: release
Build flags:  -march=native
Link flags:  -march=native
OpenMP support: ON
MMAP support: ON

Ubuntu-10.04-64bit

Reported by fotogiuliopv on 2012-06-19 07:03:45

[Beep6581]

Confirmed in tip using Gentoo 64.
Maybe related to issue 1231 or to the code cleanup in changeset 1846:4ee4f75e86ac

Reported by entertheyoni on 2012-06-19 07:35:38

• Status changed: Accepted
• Labels added: Priority-High, Component-Quality
• Labels removed: Priority-Low

[Beep6581]

Confirm, I'll try to figure it out.

Reported by lebedev.ri on 2012-06-19 13:25:52

[Beep6581]

It looks like that sharpening only applies to the preview only when zoomed to >= 100%
Try checking with zooming to 100%. Is the issue still there?

PS: Changeset: 08422f013749 - 1828, so this is not related to 1846:4ee4f75e86ac, it's
something earlier.

Reported by lebedev.ri on 2012-06-19 13:49:37

[Beep6581]

I'm just linking it to another possibly related RL issue, I'm not saying they definitely
are related. Can't check now, I'm on the phone not laptop.

Reported by entertheyoni on 2012-06-19 14:17:38

[Beep6581]

Opened the image, loaded the pp3, colors are "good".

Zoomed 100%: colors are still good, i see no sharpening.

Unchecked rl deconv, nothing changes. Zoomed out, nothing changes. 

Checked rl deconv in order to turn it on, zoomed in, colors are wrong, and imo sharpening
is still not applied.

Reported by fotogiuliopv on 2012-06-20 10:04:30

[Beep6581]

Issue 1423 has been merged into this issue.

Reported by entertheyoni on 2012-06-24 22:26:14

[Beep6581]

Just had a try, the edge sharpen is also on. Switch it off and RL deconv works.

Reported by oduis@hotmail.com on 2012-06-27 20:30:05

[Beep6581]

Can no longer reproduce, please try again using the latest builds: 4.0.9.58 1946:ef748b4553fe
or newer.
Remember to first delete your cache.

Reported by entertheyoni on 2012-07-02 19:38:06

[Beep6581]

I can reproduce it with 4.0.9.58 1946:ef748b4553fe

You have to switch four parameters together:
1) Sharpening->RL Deconvolution (ENABLE it with any settings)
2) Noise reduction (ENABLE it with any settings)
3) Lens/Geometry->Auto Fill (DISABLE it)
4) Rotate->Degree (NOT ZERO value)

Seems like it is minimal settings to reproduce this bug. 
Setting one of this parameters to another value I wrote, causing normal colors.

Reported by sghpunk on 2012-07-02 20:58:28

[Beep6581]

Ah yes, well noticed!

The colors go bad when a portion of the black canvas is visible. If I pan the preview
away from the edges so that I can't see any of the canvas, the colors are fine.

Reproduced

Branch: default
Version: 4.0.9.60
Changeset: e30296742896
Compiler: gcc 4.5.3
Processor: undefined
System: Linux
Bit depth: 64 bits
Gtkmm: V2.24.2
Build type: release
Build flags:  -march=native -fopenmp -O3 -DNDEBUG
Link flags:   -march=native
OpenMP support: ON
MMAP support: ON

Reported by entertheyoni on 2012-07-02 22:02:37

[Beep6581]

This is not an issue in the denoise branch.

Reported by entertheyoni on 2012-07-07 19:55:45

[Beep6581]

I have tried with 4.0.10.1 and the problem seems solved ;) .

Branch: default
Version: 4.0.10.1
Changeset: ef43b8eb6032
Compiler: gcc 4.7.2
Processor: undefined
System: Linux
Bit depth: 64 bits
Gtkmm: V2.24.2
Build type: release
Build flags:  -march=native -fopenmp -O3 -DNDEBUG
Link flags:   -march=native
OpenMP support: ON
MMAP support: ON

Reported by fotogiuliopv on 2013-03-22 20:01:41

[Beep6581]

Tested with:

Branch: default
Version: 4.0.9.178
Changeset: b726390164f3
Compiler: gcc 4.6
Processor: phenomX4
System: Linux
Bit depth: 64 bits
Gtkmm: V2.24.2
Build type: Release
Build flags:  -march=amdfam10 -fopenmp -O3 -DNDEBUG
Link flags:   -march=amdfam10
OpenMP support: ON
MMAP support: ON

Confirm, seems like bug is gone.

Reported by sghpunk on 2013-03-22 20:36:19

[Beep6581]

Thank you.

Reported by entertheyoni on 2013-03-26 02:52:24

• Status changed: Fixed