Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.91k stars 324 forks source link

Mouse cursor should change to arrow when hovering over detail frame even in Spot WB mode #1642

Open Beep6581 opened 9 years ago

Beep6581 commented 9 years ago

Originally reported on Google Code with ID 1658

Push the Spot WB button. The cursor changes to a dropper + small square. Click somewhere
and the WB changes. So far so good.
The cursor remain the same as before and if you click on the image the WB changes.
Now open a detail window. You cannot move it around because the cursor still works
as Spot WB.

Branch: default
Version: 4.0.9.161
Changeset: 553b1b936edf
Compiler: gcc 4.6.1
Processor: generic x86
System: Windows
Bit depth: 64 bits
Gtkmm: V2.22.0
Build type: RELEASE
Build flags:  -mtune=generic -fopenmp -O3 -DNDEBUG
Link flags:   -mtune=generic -s -mwindows
OpenMP support: ON
MMAP support: ON

Thanks for looking!
mario

Reported by siliconvalley58 on 2012-12-23 17:12:44

Beep6581 commented 9 years ago
Linux here. I can move the detail window around even when the spot-wb tool is active.
Right-click on the preview to revert the cursor to the normal one.

http://filebin.net/kq9lbn61cq/file/screencast_15fps_2M_slower_2012-12-23_214742.mp4

Michael can you reproduce this on Windows?

Reported by entertheyoni on 2012-12-23 21:52:35

Beep6581 commented 9 years ago
On Windows, sometimes Wb picker is lost, but once you click the image 1. spot wb is
applied and wb picker reappears. wb picker can be used in main preview and crop window,
no crashes.

Reported by michaelezra000 on 2012-12-24 00:08:57

Beep6581 commented 9 years ago
Maybe I was not clear. Sorry.
It is the red outline that I'm not able to move, not the detail window.
But it is true that if I right click on the image, the Spot WB cursor disappears and
turn into a cross. When I move it to the red outline it changes into a quad-arrow and
I can move the outline.
Maybe this is the correct behavior, but I think it is more intuitive if the SpotWB
cursor works only once and then revert to the previous cursor. Or reset it if opening
another window, like the detail window. What do you think?
Anyway, thanks for the workaround (the right click). It solved my immediate problem.
mario

Reported by siliconvalley58 on 2012-12-24 08:03:49

Beep6581 commented 9 years ago
Are you sure you cannot move it? With the WB spot tool enabled the cursor is a pipette.
When I hover over the red frame the cursor remains a pipette, but when I click and
drag on the red frame it does move it around.

Reported by entertheyoni on 2012-12-25 23:53:21

Beep6581 commented 9 years ago
OK, you are right, the pipette changes to quadriarrow and move the red 
frame. Really I don't know why was not working.
So the issue could be closed, but my humble suggestion is to change the 
cursor to reflect the current function (i.e. arrows when the cursor is 
on the frame).
Or at least document the current behavior. If you want, I can contribute 
to this documentation editing.
Thanks!
                         mario

Reported by siliconvalley58 on 2013-01-03 19:48:08

Beep6581 commented 9 years ago

Reported by rinni@gmx.net on 2013-01-28 13:44:08

NextTherapist commented 8 years ago

I cannot confirm that this issue is fixed. It still occurs in the Master branch. After clicking "Spot WB" the cursor looks like a pipette. When I "Open (new) detail window" after that, the cursor stays in this look and in this function. I can move the new detail window if I exactly hit the frame with the pipette, but if not, I get a new white balance.