HSV grid lines thicker

[Beep6581]

Originally reported on Google Code with ID 1747

HSV grid lines would look better if they were thicker.

Reported by entertheyoni on 2013-03-01 22:25:52

[Beep6581]

The HSV curve editor has no grid.

Reported by natureh.510 on 2013-03-01 22:37:44

[Beep6581]

ROTFL...

Hombre, you get the price for deadpan humour :-)))

Reported by heckflosse@i-weyrich.de on 2013-03-01 22:58:06

[Beep6581]

:)

Reported by michaelezra000 on 2013-03-01 23:29:45

[Beep6581]

http://i.imgur.com/RrlRVG7.png
Pixel-accuracy is pointless here, eyes should be on the preview. Thicker bars make
it easier to use this. Perhaps even thicker than this?

Reported by entertheyoni on 2013-03-02 01:12:53

---

• _Attachment: issue1747_wider_lines_1.patch_

[Beep6581]

That's really a matter of taste. I find the width sufficient, and it's thicker when
you move it, so i don't really see the point.

Reported by natureh.510 on 2013-03-02 01:18:54

[Beep6581]

The higher the screen resolution (or pixel pitch), or the brighter the theme background,
the more difficult to see what color I'm working on. I shouldn't need to put my nose
to screen :]

Reported by entertheyoni on 2013-03-02 01:25:28

[Beep6581]

It is true that is a matter of taste,but I would also agree that ticker lines here couldn't
hurt : they look really thin on my  1280 x 1024 screen as well.

Reported by msth67 on 2013-03-02 12:50:50

[Beep6581]

The thing is that I'm using thicker line width to indicate which value is beeing modified
(X and/or Y axis) when you _move_ a line or a point. How can i still indicate that
if the normal ones are already thicker? Do i have to make thick lines even thicker?

Reported by natureh.510 on 2013-03-03 13:39:41

[Beep6581]

Yes, I would like that :] This isn't a histogram, pixel accuracy is of no use.

Reported by entertheyoni on 2013-03-04 02:38:55

[Beep6581]

Here is a patch with adaptive line's thickness. The formula is quite simple:

min (max(75,graphW)/75, 8)

i.e. inner graph width/75, with a minimum of 1 pixel and a maximum of 8 pixels. The
moved line has a doubled width. So e.g. for an inner width of 300px, the line's width
will be 4px.

Reported by natureh.510 on 2013-03-17 10:36:57

• Status changed: PatchSubmitted

---

• Attachment: 1747-ThickerGridLines.patch

[Beep6581]

Hombre, this is much easier to use. In general I prefer slim interfaces, but in this
case I find thicker lines very useful, as it is easier to discern thicker colored lines
on the gray background.

Reported by michaelezra000 on 2013-03-18 01:06:21

[Beep6581]

I'll commit this patch tomorrow if nobody complains. entertheyoni, is this patch okay
for you?

Reported by natureh.510 on 2013-03-19 02:48:56

[Beep6581]

Will try and test after work Hombre.  

Reported by entertheyoni on 2013-03-19 08:22:15

[Beep6581]

Lovely :]

One small thing: when I click on a vertical line and drag it vertically, the horizontal
line turns thicker, and returns to its original state as soon as I depress the mouse
button. When I click on a vertical line and drag it horizontally, the vertical line
turns thicker, but doesn't return to its original state when I depress the mouse button,
only when the mouse cursor moves off of the line.

Reported by entertheyoni on 2013-03-20 00:51:53

[Beep6581]

Committed to Default, including the fix for comment #14.

Reported by natureh.510 on 2013-03-20 21:39:26

• Status changed: Fixed