Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.77k stars 314 forks source link

Time reduction of Noise Reduction #1955

Closed Beep6581 closed 9 years ago

Beep6581 commented 9 years ago

Originally reported on Google Code with ID 1971

I tried to further optimize Noise reduction, but I don't get more than a 5% speedup.
My experience from past optimizations is, that the reason could be the known AMD 4-way-associative
L1-cache problem. To test this thing, I would be glad, if every developer and tester
could make a test processing the same RAW with the same settings and post the timings
(average or median of 7 pictures) in this Issue. The results could help me to detect
whether it's an AMD 4-way-associative L1-cache problem or not. If it's an AMD 4-way...,
I know where to search and can try to solve it. If I can solve it, I can try further
opts....

Here's the RAW and the settings and to make it easier also a patch with timing-code.

RAW: http://www.i-weyrich.de/rt/DENOISE.NEF

Settings: Default ISO high, but Luminance set to zero in and Impulse Noise reduction
disabled

Patch: attached

Ingo

PS: Reine, you don't need to download the 50 MB RAW. You already have it :-)

Reported by heckflosse@i-weyrich.de on 2013-09-12 20:31:04


Beep6581 commented 9 years ago
Johan, thanks a lot for your test!

Reported by heckflosse@i-weyrich.de on 2014-03-12 20:42:13

Beep6581 commented 9 years ago
Committed to revision 0128a48ac35e

Reported by heckflosse@i-weyrich.de on 2014-03-14 12:58:12

Beep6581 commented 9 years ago

Reported by heckflosse@i-weyrich.de on 2014-03-16 20:36:17