Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.84k stars 321 forks source link

Get rid of no-File-Browser mode (simpleEditor) #2238

Open Beep6581 opened 9 years ago

Beep6581 commented 9 years ago

Originally reported on Google Code with ID 2254

When an image is passed to RawTherapee either on the command-line or by right-clicking
on an image and using RawTherapee to open it, it starts in an Editor-tab-only mode,
without a File Browser tab or a Filmstrip.
This issue is a feature request to get rid of that mode.

In the situation above, the desired behavior is for RawTherapee to start with that
image opened in the Editor tab (or for a new Editor tab with that image to be added
to an already-running instance of RT if using Multiple Editor Tabs Mode), and for the
File Browser tree to expand the folder which contains that image.

Reported by entertheyoni on 2014-02-19 14:01:56

heckflosse commented 5 years ago

@gaaned92 I should have mentioned that it only happens to be slow if darkframe and/or flatfield folders are set to none. Just set

DarkFramesPath=
FlatFieldsPath=

in options file. I'm already preparing a fix

gkuenning commented 5 years ago

This entire discussion amazes me, for several reasons.

First, it's entirely Windows-centric. RT works on multiple platforms, yet nobody seems to have considered its behavior in other circumstances.

Second, RT is ignoring long-established design principles, namely that invoking a program with one or more files as arguments should bring it up on just that file, and not invoke clutter. If people have been asking for a different behavior, the best answer is either "Sorry, it's just not that hard to bring up the file browser from the menu" or "We'll add that option to the preferences but the default is going to be the one that we figured out over literally decades is the most sensible."

And third, nobody should be proposing fixes that require the user to significantly alter their behavior. People shouldn't have to write .bat scripts, or edit obscure configuration files, or otherwise stand on their heads, to work around a misfeature.

@gaaned92 I should have mentioned that it only happens to be slow if darfframe and flatfield folders are set to none. Just set

DarkFramesPath=
FlatFieldsPath=

in options file. I'm already preparing a fix

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/Beep6581/RawTherapee/issues/2238#issuecomment-505094130

-- Geoff Kuenning geoff@cs.hmc.edu http://www.cs.hmc.edu/~geoff/

You know you're a parent when you hear yourself utter the words, "Throw up on Daddy's shoulder...good girl."

heckflosse commented 5 years ago

@gkuenning

Just set

DarkFramesPath=
FlatFieldsPath=

That was a hint for @gaaned92 to reproduce the bug, not to fix it. The bug @jbruchon found is already fixed in 66c9cd6

heckflosse commented 5 years ago

@gkuenning

namely that invoking a program with one or more files as arguments should bring it up on just that file, and not invoke clutter

that's exactly what rawtherapee {filename} does. It opens just the file without showing the filebrowser and queue

gaaned92 commented 5 years ago

@heckflosse confirmed when DarkFramesPath= FlatFieldsPath=

@gkuenning I am not a dev

heckflosse commented 5 years ago

@gaaned92

I am not a dev

Agreed, but you know a lot about RawTherapee, a lot more than a normal user, and also about making windows builds you know a lot more than I do :+1:

gkuenning commented 5 years ago
  • rather making negative criticism , it is better to bring positive advice and efficient help

You're right; I apologize. RT is an amazing program and I hugely appreciate the work that people have put into it. -- Geoff Kuenning geoff@cs.hmc.edu http://www.cs.hmc.edu/~geoff/

If at first you succeed, try to hide your astonishment. -- Harry F. Banks