search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.83k stars 321 forks source link

Updated Czech translation #2319

Closed Beep6581 closed 9 years ago

Beep6581 commented 9 years ago

Originally reported on Google Code with ID 2335

Hi,
Updated Czech translation file for default branch attached.

Marián

Reported by Marian.Kyral on 2014-04-07 16:19:58

Beep6581 commented 9 years ago 
Thank you Marian, but I am a little worried about committing this, as it looks like
you did not download the latest version of "Czech" from here before writing the updates
but used your own old version of "Czech" instead, therefore losing the changes I made
before committing your previous patch.

To be clear:
In issue 2173 on January 7, you uploaded Czech file (lets call it "Old). I edited this
file (lets call this edited version "New") and then committed it.
Making this update here, you should have downloaded "default" and "Czech" either from
Google Code or by pulling the repo and worked on those. It seems you did not do that,
because my changes are lost. I know I changed the whole comment block at the beginning
of the file, I don't remember what else.

Please see the attached files.
2014-01-07_Czech_before_after.diff is the difference between the file you send me in
issue 2173 ("Old") and the changes that I made when I committed it ("New").
Please re-introduce these changes into your new file from today, so the comment section
at the beginning, and browse through the diff to see if there were any other changes.

2014-04-08_Czech_2335.diff is what would change if I would commit the Czech file you
sent today.
Please also see the attached 'grep', it shows lines in this new file where you have
double-whitespace "  " and cases where you have whitespace before the forward/back-slash
" /" " \" - this is incorrect English grammar, and perhaps its incorrect in Czech too?

In the future please get the latest "Czech" and "default" files from Google Code (Cource
> Browse) or via updating the repo (hg pull && hg update -C default) before you work
on an update, that will save us from trouble :)

Reported by entertheyoni on 2014-04-08 12:24:37

Beep6581 commented 9 years ago 
OK, I'll look on it. Sorry for confusing.

How it come: The current translation system is far away to be ideal. There is no original
English string in the file, there is not a simple way, how to identify changed strings.
Only by tracking changes of "default" file in repository.

So I'm using the "default" file as the source, convert it via bash script to the ".pot"
file, merge changes with cs.po file (containing my previous version of translation).
Then I'm using special editor (Localize) to translate changes (automatically shows
strings that are new/changed). When I finish the translation, I use another script
to convert cs.po to RT's key based Czech file.

Unfortunately, the whole process ignores changes made to Czech file in repository.
And as there was not a warning about changes you made in during last commit, I did
not incorporated them to my cs.po file.

I know, this is a small gap in my translation system, but as I'm the only translator,
it is not a big issue.

Reported by Marian.Kyral on 2014-04-08 13:09:25

Beep6581 commented 9 years ago 
So updated file attached.

*) Keys order is fixed now (sort vs. sort -Vu)
*) Date format in initial comments updated
*) Double spaces fixed
*) Spaces before \n removed
*) Most of spaces issues connected with slash fixed. But not all. In some cases is
the combination " / " allowed in Czech language (and looks better in this cause). Also
in default file, there are keys where sequence " / " is used (And I think that this
is correct). Please refer the attached cs.po file for details.

BTW: did you tried the grep command to the default file? :-D
BTW2: in the default file, there are additional spaces at end of some lines. I'm not
sure, whether these spaces are mistake, or are important (could be).

Reported by Marian.Kyral on 2014-04-08 19:39:07

Beep6581 commented 9 years ago 
" / " is a syntax error as far as I know in English, however I think its perfectly acceptable
in some cases in a GUI.

No I have not tried grepping the default file for those, I did a major revision of
default not long ago and I assumed it was all correct :D Will check.

Yes some lines in default have spaces at the end, they are intentional. This is not
good practice, the correct way would be to not have them in the language files and
to use the GTK+ equivalent of padding where needed, but as I'm a GTK+ noob I can't
fix that :] Did you preserve them?
I've started slowly learning Python, hopefully this year I can write a tool like generateTranslationDiffs
which also checks for beginning and ending lines with the same characters as in default,
which lets you know when an already-translated line in default changes so you can update
the translation, and which, being Python, is cross-platform.

Reported by entertheyoni on 2014-04-08 20:02:04

Beep6581 commented 9 years ago 
Thank you, looks good!
One last thing, TP_RGBCURVES_LUMAMODE_TOOLTIP is still in English, would you like to
translate that before I commit?

Reported by entertheyoni on 2014-04-08 20:18:28

Beep6581 commented 9 years ago 
Well, long time age (just after RT was opened) I tried to change RT localization system
to gnu gettext. But before I've finished, a big changes in code started and code, I've
worked on, become obsolete. So I've made a second attempt, but I did some mistake and
RT does not worked correctly and I was not able find what is wrong.

Maybe now is a time to a third attempt. The GNU gettext is almost standard in open
source, it is multi-platform and there are editors available on all platforms.

It will eliminate duplicities for translation, allow to add context to the messages
to help translators to choose a correct translation. And also allows plurals (image/images).
This is not possible with current keys based system.

Also a lot of gettext utilities exists. Update translation files with new/updated strings
is simple. Translator can see, what strings are new, what strings were updated and
needs revision. All in one place. You can generate statistics for translations, and
even it is possible to connect translations with some web service and allow normal
users to help with translating.

I thinks it is not needed to invent another translation system. All necessary already
exists.

Reported by Marian.Kyral on 2014-04-08 20:54:57

Beep6581 commented 9 years ago 
TP_RGBCURVES_LUMAMODE_TOOLTIP translated.

Reported by Marian.Kyral on 2014-04-08 21:05:07

Beep6581 commented 9 years ago 
Thank you, committed.

A good time for gettext would be after 4.1 is tagged, but would that force us to use
that horrible, primitive, unstable, we-don't-update-our-website program I've had the
displeasure of using three years ago called Poedit?

Reported by entertheyoni on 2014-04-09 06:43:35

Beep6581 commented 9 years ago 
Thanks.

Poedit is not the only one editor. There are alternatives: http://alternativeto.net/software/poedit/

I'm using lokalize, never tried poedit. And for example Pootle (Online translation
platform) looks nice (http://alternativeto.net/software/pootle/ ) - check screenshots
there.

Reported by Marian.Kyral on 2014-04-09 07:45:34

Beep6581 commented 9 years ago 
Aah, that would be wonderful!

Reported by entertheyoni on 2014-04-09 07:51:16