Edit in External Editor makes malformed command line on some CR2 images starting with underscore _

[Beep6581]

Originally reported on Google Code with ID 2439

command line: gimp "/tmp/_MG_6574.ti
Text ended before matching quote for " was found. (The text was »gimp "/ tmp/_MG_6574.ti«)
terminate called after throwing an instance of 'Glib::ConvertError'
Cancelled

sometimes rawtherapee does use the correct path for the temporary tiff file.
at least the file "_MG_6574.ti" is in /tmp while it should be named as tif but ok...
and the quote isn't closed when exporting.

openSUSE 13.1, official repository, rawtherapee 4.1.30.2774-1.1

Reported by Marco.Laux on 2014-07-03 13:02:16

[Beep6581]

How to reproduce?

Reported by entertheyoni on 2014-07-03 13:10:07

[Beep6581]

i am sorry for not providing enough information.

the file is a .CR2 canon raw file. the path is on an external hdd under /run/media/user

it doesn't matter if i change some settings or just export it to gimp. i tried to use
the default GIMP option and i entered the path to gimp (/usr/bin/gimp) manually. it
always crashes - but only on CR2 files. i tried a .jpg just for fun and the export
string is always ok.

Reported by Marco.Laux on 2014-07-03 13:15:02

[Beep6581]

Please upload a sample file this happens with to www.filebin.net and paste the link
here.

Reported by entertheyoni on 2014-07-03 13:47:21

• Labels added: OpSys-Linux
• Labels removed: Priority-Low

[Beep6581]

http://filebin.net/1c1mn62prn

Here is an example file, but it happens with all my RAW files. Thank you for having
a look.
But could the source file be the problem? I would think the export string to the destination
file is just wrong - but correct me if the issue could be more complex.

Reported by Marco.Laux on 2014-07-03 14:03:03

[Beep6581]

btw the file should be named "_MG_2426.CR2" - it seems the underscore at the beginning
was trimmed by filebin

Reported by Marco.Laux on 2014-07-03 14:04:47

[Beep6581]

I don't know, first we need to reproduce it :]

Reported by entertheyoni on 2014-07-03 14:06:30

[Beep6581]

Cannot reproduce in Gentoo with _MG_2426.CR2 and MG_2426.CR2 using 4.1.31 (ca29ce369774
+ clut patch 11)

rtgui/editorpanel.cc line 1244 onwards.

Please upload your options file from ~/.config/RawTherapee4.1/options

Reported by entertheyoni on 2014-07-03 15:00:47

• Status changed: WorksForMe

[Beep6581]

Reported by Marco.Laux on 2014-07-03 15:07:31

---

• Attachment: [options (copy)](https://storage.googleapis.com/google-code-attachments/rawtherapee/issue-2439/comment-9/options %28copy%29)

[Beep6581]

could it be my libglib version that propably differ?
well propably not. it also happened with fedora and arch when i remember correctly.

Reported by Marco.Laux on 2014-07-03 15:12:55

[Beep6581]

I still cannot reproduce even with your options file.

By the way, your gimp path has an extra whitespace at the end of it due to which it
won't work, though your RT is set to not use this custom path but just the default
"GIMP" option in Preferences > General > External Editor

Please try deleting (or renaming) your options file while RawTherapee is closed, then
run it and try again without touching anything in settings. Also try downloading the
file you uploaded to filebin (you can add the _ in front of it), to eliminate the possibility
that you have some characters in the filename which we cannot see, which filebin removed,
and which are causing this problem.

Reported by entertheyoni on 2014-07-03 15:22:57

[Beep6581]

ok. tried everything and it only happens with the underscore at the beginning of the
filename.
i also moved it to my home directory so that the filesystem shouldn't be an issue.

without underscore at the beginning - it's working. with - it's not.

but i cannot rename all my backuped photos - that's really no option ;)

Reported by Marco.Laux on 2014-07-03 15:33:10

[Beep6581]

btw: i downloaded the uploaded file and manually added the underscore to be sure

Reported by Marco.Laux on 2014-07-03 15:34:31

[Beep6581]

Weird, I just cannot reproduce here. Tried from /tmp and from /run/media/drslony/usb_data/,
ext2 or ext4, locale set to en_US.utf8

Reported by entertheyoni on 2014-07-03 15:52:46

[Beep6581]

ext4 and de_DE.uft8 is set here
well since i experienced this issue in other distributions i don't know what could
be the issue as well

Reported by Marco.Laux on 2014-07-03 16:32:42

[Beep6581]

thank you for having a look

Reported by Marco.Laux on 2014-07-03 16:35:05

[Beep6581]

I'll leave it open since you can reproduce.

To eliminate some packaging issue, do you feel like compiling your own RT to test?
It's quite easy: http://rawpedia.rawtherapee.com/Linux

Reported by entertheyoni on 2014-07-03 16:43:30

[Beep6581]

it works now. compiled from source... thank you for suggesting it

Reported by Marco.Laux on 2014-07-03 17:11:48

[Beep6581]

Yay! If a version of RawTherapee newer than 4.1.30 from the official OpenSUSE repo shows
this problem again, please file a bug report in OpenSUSE's bug tracker, as it would
then seem that they patched something which causes this.

Reported by entertheyoni on 2014-07-03 18:25:57

• Status changed: Invalid

[Beep6581]

well i have this bug again, fedora 21, rawtherapee compiled from source

underscore at the beginning of the filename results in a crash.

Reported by Marco.Laux on 2014-11-16 08:34:19