Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.81k stars 318 forks source link

Better support for DCP LookTable #2721

Closed Beep6581 closed 9 years ago

Beep6581 commented 9 years ago

Originally reported on Google Code with ID 2739

Enhancement request for better support for DCP LookTables:
1- The LookTable should be applied "after any exposure compensation and/or fill light
stages, but before any tone curve stage", not at the beginning of the pipeline as is
currently the case.
2- Ability to turn off the LookTable.

References:
http://rawpedia.rawtherapee.com/Color_Management#Custom
http://dcptool.sourceforge.net/DCP%20FIles.html
https://shalamander.wordpress.com/2014/08/04/dng-tools-in-linux/

Reported by entertheyoni on 2015-04-09 22:34:36

Beep6581 commented 9 years ago
Before: http://i.imgur.com/X5hcWcO.png
After: http://i.imgur.com/yi1YpdC.png

Reported by entertheyoni on 2015-07-15 17:44:57


Beep6581 commented 9 years ago
Committed in Revision: 71f2b1e8dc97

Can we close?

Reported by entertheyoni on 2015-07-16 16:56:57

Beep6581 commented 9 years ago
The layout is fine now, thanks DrSlony :).

But .. shouldn't we evaluate the changes by measures before closing issues related
to color fidelity/profiling ? .. 

I can make some measures in a few hours using Oduis' colorchartcheck on cc24 shots,
but I don't have a clear understanding about what exactly should I measure, which dcp
profiles are affected etc.
A summary of the changes made and the expected difference in color rendering would
help ..

BTW, I think RT needs to have a reliable and easy to use process for this kind of evaluations.
I am thinking of a companion utility or even a new color profiling tab in RT gui, to
make easy and reliable measures and provide results .. 
For a start, just export RGB and Lab values from the cc24 patches by just inserting
the center coordinates of the four corner patches :)   
DcamProf's code could be a base for a lot more .. 

Reported by iliasgiarimis on 2015-07-17 10:07:09

Beep6581 commented 9 years ago
why is gc not showing #52's date in list ?

Reported by iliasgiarimis on 2015-07-17 11:29:54

Beep6581 commented 9 years ago
The images I tested look as they did before the patch minus the false colors in the
transition to highlights.
"using Oduis' colorchartcheck on cc24 shots, but I don't have a clear understanding
about what exactly should I measure, which dcp profiles are affected"
Same problem here, but in addition I can't use his Windows-only tools.

#54 what do you mean? What list?

Reported by entertheyoni on 2015-07-17 12:23:13

Beep6581 commented 9 years ago
> #54 what do you mean? What list?

https://code.google.com/p/rawtherapee/issues/list?can=2&q=&sort=-modified&colspec=ID%20Opened%20Modified%20Type%20Status%20Priority%20Milestone%20Summary%20Owner%20Stars

30mins After I posted #53 I browsed with the abobe settings (sorted by "modified.sort
down) and the result showed as if the last message was #52 instead of #53 !! 

Reported by iliasgiarimis on 2015-07-17 13:35:54

Beep6581 commented 9 years ago
#53 dcp profiles with looktables and curves are affected, and baseline exposure offset.
Profiles with only a huesatmap is not affected.

The change is that looktable + curve is applied after exposure (and highlight/shadow
compression, highlight/shadow map).

Reported by torger@ludd.ltu.se on 2015-07-17 13:47:45