Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.91k stars 325 forks source link

instability with wavelet sharpening using jpgs #2820

Closed Beep6581 closed 9 years ago

Beep6581 commented 9 years ago

Originally reported on Google Code with ID 2840

Rt 238 64 bit unstable as reported by several in the general discussion so maynot not
 be specific to my machine. Running win7 core 4 with 8gb memory, Win task master looks
ok at crash 

I added this to 2702 yesterday then wondered if this should be a separate issue
the jpg i was testing  is on flicker at:
https://www.flickr.com/photos/125194658@N05/18943273793/sizes/o/ 

Set edgesharpening to about 50 with edge detection checked All other settings at default.
view at 100 percent. Move the view around rapidly ending on left side of the image
where building changes to sky. After about a minute of this RT crashes. Look to me
that RT can't keep up with the changes.

More experiments. Tried this unstability test on build 222 231 234 and 238. They all
crashed. Had occasional random crashes with all builds but 238 seemed worse than others.

If someone sends me debug versions of the builds I'll set up gdb and try to debut the
problem on my machine

Reported by scribble1@charter.net on 2015-07-12 15:48:19

Beep6581 commented 9 years ago
I made some changes that should improve the instability ... but I'm not sure that everything
is resolved.
For simplicity, I added these changes to the current patch  issue2811

:)

Reported by jdesmis on 2015-07-13 06:35:08

Beep6581 commented 9 years ago
I'll test for stability as soon as someone posts a build with the patch. To crash RT
with this procedure it appears that you need a large jpg (5214x2332) with an abrupt
change in local contrast like the building to sky at the left end. With lower resolution
jpgs a crash does not happen.

On a better note, your noise reduction with sharpening is excellent. I've worked with
an ISO50000 raw and jpg from a Leica Q Typ 116 and gotten excellent sharpening without
excessive noise. Great work.

Reported by scribble1@charter.net on 2015-07-13 20:43:56

Beep6581 commented 9 years ago
This procedure for crashing RT in less than a minute no longer works with build 265.
As for the real problems I hoped this would help fix, random crashes, I have not worked
enough with the build to comment. 

Reported by scribble1@charter.net on 2015-07-29 21:10:28

Beep6581 commented 9 years ago
I crash in the last ten days. looks stable 

Reported by scribble1@charter.net on 2015-08-08 09:04:54

Beep6581 commented 9 years ago

Reported by entertheyoni on 2015-08-08 09:16:54