Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.9k stars 323 forks source link

Lenses are not recognized on Panasonic cameras #2998

Closed iliasg closed 7 years ago

iliasg commented 8 years ago

Lenses are not recognized on Panasonic cameras. I tried with new and old Panasonic models with new and old (4.2.0) RT versions. I cannot find any Panasonic lens data in xxx.. atribs.cc files. Although I found Panasonic lens data in Olympusattribs.cc Is RT supposed to read the lens info for Panasonic bodies from exif ?.

Beep6581 commented 8 years ago

"I found Panasonic lens data in Olympusattribs.cc" Do you mean the Lumix entries? exiftool has no "Panasonic" camera category, and it has the Lumix lenses in the "Olympus" category.

If you have xmlstarlet and exiftool installed:

xmlstarlet sel -T -t -m "taginfo/table/tag[@name='LensType']/values/key" -v "concat(@id,'   ',val)" -n < <(exiftool -listx -Olympus:all) | sed -r -e 's/   / = /' -e 's| F([0-9]+)| f/\1|g'
iliasg commented 8 years ago

OK .. but RT fails with Panasonic bodies while it's fine with Olympus bodies ..

ghtma commented 7 years ago

Unfortunately this issue is still open and not assigned. Any chance to get it fixed in the near future?

Beep6581 commented 7 years ago

@ghtma can you upload some sample raw files? Use http://filebin.net/

ghtma commented 7 years ago

@Beep6581 I have uploaded three files, one for each lens I own. The blue text in the image is the "LensType" read with ExifTool.

ghtma commented 7 years ago

Thanks for fixing the bug. Is a nightly build available to test it?

Beep6581 commented 7 years ago

@ghtma you need a build from 2017-04-18 or newer. There are none yet, but when one is made it will appear here: https://discuss.pixls.us/t/download-rawtherapee-development-builds/2924 That's assuming you use Windows - you didn't state which OS you use.