search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.74k stars 311 forks source link

Custom dcp is lost when opening dcp dialog and hitting cancel button after restart of rt #3013

Open heckflosse opened 8 years ago

heckflosse commented 8 years ago

To reproduce:

Open Image Select a custom dcp in Colour Management/Input Profile Close RT Start RT Open the Image with custom dcp Open the 'custom dcp' dialog and hit the cancel button => custom dcp shows '(none)' though the custom dcp is still used

adamreichold commented 8 years ago

Tried to reproduce using master and gtk3 running Linux/x86-64 with out success. The only way I am able to reproduce is this by remove/renaming the DCP file between closing and starting RT.

But then again, no signal in RT is triggered and it seems this behaviour is prescribed by GtkFileChooserButton, i.e. in gtkfilechooserbutton.c in function update_label_and_image, the fallback text is used if the file's meta data could not be queried. The end result is that we keep the same file since no change signal is emitted, but the file chooser button does not display this. (Even one puts back the file, after closing the dialog using cancel and then restarts RT, the profile is restored properly.)

So this is a Gtk bug?