search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.81k stars 318 forks source link

OnePlus One (smartphone) DNG file support #3349

Closed rfeesh closed 7 years ago

rfeesh commented 8 years ago

For some reason that I can't seem to find, RawTherapee crashes when I load this image taken on my OnePlus One. Other software seems to have no problem, but RawTherapee shows the photo as black, and then crashes when I double click to open it. Other DNG's of shorter time open fine, so I am unsure of the problem. PC Specs: Intel 6700HQ Win10 16GB RAM Photo Info: ISO 100 Shutter Speed 99s RawTherapee Version: 4.2.1005

NextTherapist commented 8 years ago

Your file seems to be non-standard in some way. I squeezed it through the Adobe DNG Converter and got this file, which opens without a problem: DNG7.1

rfeesh commented 8 years ago

That's very odd. It works now with the file you posted, but the shutter speed shows up as way off (1/13s). This seems to happen with one specific app and I have no idea why. The image renders perfectly fine in google drive and snapseed, so I'm not sure what the problem is. I'd like to be able just to have RT ingest them without having to put each file through conversion.

UPDATE: Tried to open said image with Partha's darktable and it worked fine but I really would like it to work in RT. Not sure of the problem.

iliasg commented 8 years ago

@alpharhino google drive and snapseed do not decode DNGs they just extract and display the embedded in DNG jpeg preview. Darktable uses libraw as a decoding engine which looks like has better support for DNGs. Can you report about what WB temp/tint Darktable reports .. and the quality of color ?

Latest Dcraw 9.27 (RT's decoding engine) also fails on this file, renders it as Black. If anyone can pass the message to Dave Coffin please do (my e-mails are rejected).

There is one more problem with this file. It uses an unusual color profile with no colormatrix1,2 and this is a multiple problem for RT which relies on colormatrix2 for WB calculations and color correction, so

In the meanwhile we can

Too much trouble for a very small user base ..

rfeesh commented 8 years ago

I've created the DCP from one of my pictures but I don't quite understand how to apply it to my pictures. I created the XML, put it in the DCP profiles directory, but it doesn't seem to change anything and the white balance is still wonky.

iliasg commented 8 years ago

In order to have a normal WB behavior, you have to change the colormatrix2 value to the one suggested .. use exiftool for this.

If you already have the extracted dcp

rfeesh commented 8 years ago

Got it fixed! Here is a comparison of the photo with and without the color profile (and a few other tweaks). Thanks for all your help

Beep6581 commented 8 years ago

@alpharhino now that you've been helped, for the benefit of everyone else, you could document step by step what needs to be done to correctly read that raw file. See here to learn how to write numbered lists.

heckflosse commented 8 years ago

Can we close this issue?

iliasg commented 8 years ago

Yes .. close it. The links of the problematic file expired .. I found some samples of the same smartphone (I think ..) which have no problem !! https://www.dropbox.com/sh/30pje0h85il030b/AAAvdPlNpgms-MXPhsHVfFlra?dl=0 So I think the problematic file was a special case (bad firmware ?) which should be corrected by now ..

Lets just keep in mind that it would be usefull to