Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.94k stars 327 forks source link

Weird behavior of Auto white balance (Canon 7D Mark II) #3355

Closed fliker09 closed 4 years ago

fliker09 commented 8 years ago

Branch: master Version: 4.3+git20160612-324~ubuntu16.04.1 Changeset: daily Compiler: x86_64-linux-gnu-gcc 5.3.1 Processor: x86_64 System: Linux Bit depth: 64 bits Gtkmm: V2.24.4 Build type: Release Build flags: -std=c++11 -O3 -std=gnu++11 -Werror=unused-label -fopenmp -Werror=unknown-pragmas Link flags:
OpenMP support: ON MMAP support: ON

Source file: https://filebin.net/dywoqsmtxp72pmp9/C34A3915.CR2

Auto WB: autowb

Camera WB: camerawb

Is it a bug or I am doing something wrong?

TooWaBoo commented 8 years ago

You don't do anything wrong. This happens when the image has clipped highlights.

heckflosse commented 8 years ago

Maybe we should lower this constant? @iliasg what do you think?

TooWaBoo commented 8 years ago

Auto-WB with clipped highlights sets the wrong tint. I always set tint back to its initial value with a little bit of fine tuning..

fliker09 commented 8 years ago

Very strange... This image is one from a HDR stack. I am using RawTherapee from terminal, in an automated way. Till now this problem appeared only once... Many other stacks worked fine. Now it got out of hands, after switching to Git version instead of repo one. Did you change something in White Balance processing?

Beep6581 commented 8 years ago

You should not be using auto white balance on a HDR stack.

after switching to Git version

Which version did you use before? Did you try to reproduce the problem in photos you processed in that older version?

iliasg commented 8 years ago

@heckflosse

Maybe we should lower this constant? @iliasg what do you think?

May be .. and also exclude very dark areas and if possible corners which usually distort average level and especially when the image circle is smaller than the frame's diagonal. I have only an hour available now and no time for the next days .. but a raw sample of this HDR stack mode would help .. maybe the black/white Levels are different for this mode than our camconst.json constants :(

fliker09 commented 8 years ago

Here you go (rest of the files, one I already gave you): https://filebin.net/ylte3thrqk52wirk/C34A3912.CR2 https://filebin.net/ylte3thrqk52wirk/C34A3913.CR2 https://filebin.net/ylte3thrqk52wirk/C34A3914.CR2 https://filebin.net/ylte3thrqk52wirk/C34A3916.CR2 https://filebin.net/ylte3thrqk52wirk/C34A3917.CR2 https://filebin.net/ylte3thrqk52wirk/C34A3918.CR2

fliker09 commented 8 years ago

Any progress so far? Will there be any improvements for fish-eye photos as you mentioned?

fliker09 commented 8 years ago

Same problem detected with Nikon D7100. Yes, again fish-eye. Is there any hope for improvement?

fliker09 commented 8 years ago

One more time, desperate one, is there any hope? :\

heckflosse commented 8 years ago

@fliker09 I'll try to solve this now

heckflosse commented 8 years ago

@fliker09 Can you upload your raw file again please. Link seems to be expired. Thanks in advance.

Ingo

Beep6581 commented 8 years ago

https://filebin.net/canon7dmkii

iliasg commented 8 years ago

@heckflosse Ingo, I checked the files .. everything is normal regarding raw Black/White Levels.

Iliah Borg says that at least for Canon models there is a possible issue with values at the top 1/3 stop (non linear, so unreliable for WB calculations) .. there exists a related tag in exif:maker notes named by exitool as "linearityUpperMargin" which is usually set at 10000 (14bit).

The other issue is for very low values where the read noise (electronic noise added on signal) distorts WB because read noise (WB = 1,1,1,1) is dominant there. My opinion is that we should exclude values lower than stdev of black area or maybe lower than 2X stdev. The problem is that read noise (i.e stdev of black frame) varies alot among various models and also varies alot depending on ISO. For Canons we can calculate black_stdev from the optically black area (the area from where Dcraw/RT calculate BlackLevel), but other brands give no optically black data.

For referense .. 7DII's at ISO100 stdev is around 5, for the other model mentioned (Nikon D7100) is around 2 (14bit) .. the lowest I know is for Nikon D7200 around 1 (14bit)

barretina commented 7 years ago

Hello,

On Nikon D7200:

I used to have a Nikon D80 camera which worked very well with RawTherapee; now I've moved to D7200 and can't use it any more. Oh I'm on linux Ubuntu 16.04 LTS installed on a laptop computer.

Attached: screenshots of the process (RAW file too large to upload)

Hope you can fix it soon...

Thank you very much 1 - as opened - compressed histogram magenta hue camera wb 2 - after automatic levels 3 - after auto wb

TooWaBoo commented 7 years ago

@barretina

My guess, wrong camara input profile selectet or wrong settings.

barretina commented 7 years ago

TooWaBoo you're probably right. Similar thing happens with UFRaw and it displays a warning: "White balance configuration not available for your camera model"...

heckflosse commented 7 years ago

@barretina I guess rt 4.2.0 simply is too old to support Nikon D7200 correctly...

Beep6581 commented 7 years ago

@barretina Support for the Nikon D7200 was added on 2015-04-28 in commit 34a419a6caca30d219a90fcfcbe8b85956f6b4b1. RawTherapee 4.2.0 is from 2014-10-24.

barretina commented 7 years ago

Thanks all and sorry for the delay. Just updated the rawtherapee version. It's much better (even if not perfect yet, maybe the profile needs further fine tuning). Thank you anyway! Cheers

sky should be bright blue

heckflosse commented 7 years ago

@barretina That's a screen shot from rt 4.2.0, not from current rt...

barretina commented 7 years ago

@heckflosse You are right... I updated to the latest stable version according to http://rawtherapee.com/downloads: "To install RawTherapee follow these simple steps:

Open the terminal
Paste this code into it:

sudo add-apt-repository ppa:dhor/myway
sudo apt-get update
sudo apt-get install rawtherapee"

I'm using Ubuntu linux. I did it again and it said "rawtherapee is already the newest version (4.2-4)." So it looks like the latest stable version is 4.2.0... (or 4.2.4?)

I have now updated to the development version: "If you want a development version:

sudo apt-get install rawtherapee-unstable"

I usually do not install development versions, but it seems it have solved the issue: captura de 2016-12-18 16-48-57

Then it looks like the problem's solved. THANK YOU ALL!!

Marçal

Beep6581 commented 4 years ago

Closing as the link to the raw file has expired and the new Auto-ITC white balance algo probably handles this better.