Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.77k stars 314 forks source link

Path to ICC profiles #3487

Open ghost opened 7 years ago

ghost commented 7 years ago

Hi, the path to the ICC profiles as set in preferences is only used for the first image. Once I open the next image and want to set the ICC profile, the path has changed to ...\program files\rawtherapee. One has then to click through the windows folder to get to the folder C:\Windows\System32\spool\drivers\color, which is quite annoying.

In preferences - Color management - path to ICC profiles - links are not supported. Why? I have set a link to the folder C:\Windows\System32\spool\drivers\color in my picture folder, so I can get there quickly. This unfortunately cannot cannot be used in preferences.

I had tried to use GitHub yesterday for this report, but obviously was doing something wrong there. Thus I repeat the report here.

Hermann-Josef

My version information: Branch: gtk3 Version: 4.2.1291 Changeset: a6fc7cd37d99b53ea83f8c9c7adc8fec2096aaf6 Compiler: gcc 5.3.0 Processor: generic x86 System: Windows Bit depth: 64 bits Gtkmm: V3.18.0 Build type: release Build flags: -m64 -mwin32 -mthreads -std=gnu++11 -mtune=generic -Werror=unused-label -fopenmp -Werror=unknown-pragmas -msse -msse2 -mwindows -fopenmp -Wno-aggressive-loop-optimizations -DNDEBUG -O3 Link flags: -m64 -mwin32 -mthreads -static-libgcc -mtune=generic -mwindows -s -O3 OpenMP support: ON MMAP support: ON

heckflosse commented 7 years ago

@Jossie2 Thanks for reporting the bug. Confirmed also using master branch. I have a look now

Beep6581 commented 7 years ago

SETM, Gtk+ 3.20.9 in Linux, cannot reproduce. Furthermore, AFAIK, that option is there only for the monitor ICC profile. That has nothing to do with input color profiles. I would consider renaming the label to be more clear about this the correct solution to this issue.

Beep6581 commented 7 years ago

I reproduced the bug. Steps:

  1. Open a photo, click "Custom", select an ICC profile in ~/somefolder/foo.icc
  2. Open a photo either with no PP3 associated, or with a PP3 which does not use "Custom".
  3. Click "Custom". Opens in home instead of the last-used folder.

If I now open the previous photo and click Custom, it will correctly open ~/somefolder/ because it was saved in the PP3 under the InputProfile key, but if I open a photo which does not use Custom, it should open in the last-used folder, but instead opens in home.

Beep6581 commented 7 years ago

Still valid. The first time an image is opened, launching the file browser for the custom input profile opens the folder set in Preferences, but following the steps above, it then opens the last of the bookmarked folders in the first of three sections, which is strange because in my case this bookmark has nothing to do with RT (it's work stuff). imgur-2017_09_15-14 01 49