Some keyboard shortcuts not working in macOS

frspp commented 7 years ago

"Fit crop to screen" keyboard shortcut ALT+f isn't working. (FYI: CMD+f does nothing). -- I would change the behaviour anyways: less keys needed for "fit crop to window" ie. only F, more for "fit image to window" ie. alt+F; if no crop then use less keys (only "F") to fit whole image to window.
"Show/hide the right panel": alt+i shows info overlay on editor window, not show/hide the right panel as proposed in that button's hint.
Snapshots > Add alt+s: doesn't work.
Editor > right panel, chancing tabs: alt+something doesn't work.
Changing between Editor - Queue - File browser tabs with ctrl+fN doesn't work because for example ctrl+(fn+)f3 is reserved for OSX's builtin functions.

OSX 10.11 RT 4.2.876

reagle commented 7 years ago

Yes, I've long used RT on linux, but many of the shortcuts don't work on El Capitan: homebrew rawtherapee: 4.2.1025 .

Beep6581 commented 7 years ago

@frspp @reagle are you capable of making your own builds to test if we make a patch?

reagle commented 7 years ago

Unfortunately, I am not. I'm new to Mac and use homebrew; the build instructions seem to require MacPorts.

reagle commented 7 years ago

BTW: I installed rawtherapee: 5.0-r1_gtk3 and this problem still exists.

Beep6581 commented 7 years ago

@ion12 @helmi03 @partha1b are you interested in testing?

Partha1b commented 7 years ago

@Beep6581 Sure. What am I testing? All the OSX shortcuts?

@reagle Do you have a list of shortcuts that are not working? Are you using my builds perchance?

reagle commented 7 years ago

As above, I can test binaries but not build.

Beep6581 commented 7 years ago

@Partha1b see the first comment. The first step is to confirm that the shortcuts don't work and agree to the proposed changes.

ion12 commented 7 years ago

@Beep6581 @Partha1b
Hi! I Actually already tested this a while ago and wanted to write in, but been very busy and didn't even find time to finish up with the bundleing updates yet :( ...

ctrl+F2..F4 keys are indeed clashing with system shortcuts and should be adjusted for macOS. Apple provides a list of reserved shortcuts that should not be used by other applications: https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/Keyboard.html#//apple_ref/doc/uid/20000957-CH84-SW3

The option/alt key on the mac is not just a modifier, it also shifts the keyboard group, which means it also modifies all the keyvals, and unfortunately no alt-based shortcuts will work on macOS as the code now stands.

It seems odd that GTK+ doesn't provide a simple c++/gdkmm method to handle this issue on the mac, but I went through a lot of GTK+ docs, forums, etc. and if there is one I couldn't find it. Darktable and GIMP seem to handle shortcuts with C rather than the C++ bindings, which is probably the way RT should do it as well, but this is a task for someone who is familiar with C and GTK+ (and then it would be possible to also create user-customizable shortcuts), and beyond my current skills.

If there is no one who is available for that: Solution is either to remap the alt modifier to a different modifier for the mac, or use the macOS specific hard-coded keyvals that are equivelant to alt+keyval on linux/windows. The con to this latter approach is that I think different language mac keyboards might have some different layouts for the alt/option keyboard group and some shortcuts might not work unless hardcoded for all different possible languages (?? not really sure)

relevant code as far as I can tell is in these 4 files:

rtgui/filebrowser.cc rtgui/filecatalog.cc rtgui/toolbar.cc rtgui/toolpanelcoord.cc

I suggest:

Change the primary modifier on the mac from ctrl to apple/command. It is more in tune with apple standard (and incidentally would also resolve the ctrl+Fn key issue...) change
```
bool ctrl = event->state & GDK_CONTROL_MASK;
```
to
```
if defined(__APPLE__)
bool ctrl = event->state & GDK_MOD2_MASK;
endif
```
OR alternatively, add:
```
GdkKeymap* key = gdk_keymap_get_default();
GdkModifierType primary = gdk_keymap_get_modifier_mask(key, GDK_MODIFIER_INTENT_PRIMARY_ACCELERATOR);
```
and change
```
bool ctrl = event->state & GDK_CONTROL_MASK;
```
to:
```
bool ctrl = event->state & primary;
```
(this needs to be checked for linux/windows, it works for mac and is possibly a more elegant solution than os-specific ifdefs)
Change alt modifier to ctrl modifier for the mac, OR hard-coded keyvals, OR someone who actually is an expert with GTK+ makes a better fix...
@Beep6581 There is also a non macOS-specific issue: non-modified keys are now detected in RT code with!ctrl && !shift && !alt style checks. GTK+ recommend against that because caps-lock/num-lock/etc. false detection issues. The recommended way is:
```
GdkKeymap* key = gdk_keymap_get_default();
GdkModifierType modifiers = gdk_keymap_get_modifier_mask(key, GDK_MODIFIER_INTENT_DEFAULT_MOD_MASK);
bool all = event->state & modifiers;
```
and then to check against !all

reagle commented 7 years ago

I'm not able to follow the discussion here, but it looks like a step has been made forward. What's next? I'm happy to test a binary.

Partha1b commented 7 years ago

@reagle We haven't actually implemented @ion12's suggestions yet.

@Beep6581 What do you think? Do you want me to git pull dev and implement to test?

Beep6581 commented 7 years ago

@Partha1b go ahead, but what is more urgent is getting a macOS build of the latest dev https://github.com/Beep6581/RawTherapee/issues/3678#issuecomment-292803888 so that users can verify that the recent major changes work and so that 5.1 can be released for macOS.

reagle commented 7 years ago

Looking forward to the shortcuts and using 5.1!

reagle commented 7 years ago

5.1 just showed up in homebrew; any news on this issue?

Benitoite commented 7 years ago

Here is a dev branch build built this evening: https://filebin.net/tezci9bhxfmv9tod/RawTherapee_OSX_10.9_64_5.1-60-g2fcb7d96.zip I haven't a clue what the keyboard shortcuts are in RT, but you may test them with this to see if they are fixed yet.

reagle commented 7 years ago

Thankyou @Benitoite, but I doubt it is in the dev version; I was hoping to hear from @ion12, @Beep6581, and @Partha1b about plans to move forward.

Partha1b commented 7 years ago

@reagle Sorry, I've been very very busy and have been completely out of this thread and have not looked at RT for a while. :(

reagle commented 7 years ago

@Beep6581, I was curious, why was the 5.1 release more important than the keys? RT without its shortcuts keys isn't really RT. (Just trying to understand.)

Beep6581 commented 7 years ago

@reagle while this issue continues getting very little interest, many other enhancements, improvements, new tools, speedups and bug fixes have been made which users of not only macOS but also Windows and Linux can enjoy when a release is made.

You can help by making a list of shortcuts which don't work. http://rawpedia.rawtherapee.com/Keyboard_Shortcuts

reagle commented 7 years ago

@Beep6581, @ion12 laid it out well above, but if it helps to see his concerns about:

nonfunctional alt
mapping ctrl to super/command
system conflicts

I hope this will help:

Below don't work using the ctrl key, but on a Mac it should be super/command key:

|-
| Anywhere
| {{k|Ctrl}} + {{k|F2}}
| Switch to the File Browser tab.
|-
| Anywhere
| {{k|Ctrl}} + {{k|F3}}
| Switch to the [[The_Batch_Queue | Queue]] tab.
|-
| Anywhere
| {{k|Ctrl}} + {{k|F4}}
| Switch to the [[The_Image_Editor_Tab | Editor]] tab.

Below don't seem to work with ctrl or command key

|-
| Anywhere
| {{k|Ctrl}} + {{k|c}} or {{k|Ctrl}} + {{k|Insert}}
| Copy the processing profile.
|-
| Anywhere
| {{k|Ctrl}} + {{k|v}} or {{k|Shift}} + {{k|Insert}}
| Paste the processing profile.
|-
| Anywhere
| {{k|Ctrl}} + {{k|Shift}} + {{k|v}}
| Partial-paste the processing profile. Pay attention to the [[The_Image_Editor_Tab#Processing_Profile_Selector|processing profile fill mode]]!

No alt keys work, as @ion12 wrote above.

|-
| Editor, File Browser
| {{k|Alt}} + {{k|e}}
| Switch to Exposure tab.
|-
| Editor, File Browser
| {{k|Alt}} + {{k|d}}
| Switch to Detail tab.
|-
| Editor, File Browser
| {{k|Alt}} + {{k|c}}
| Switch to Color tab.
|-
| Editor, File Browser
| {{k|Alt}} + {{k|t}}
| Switch to Transform tab.
|-
| Editor, File Browser
| {{k|Alt}} + {{k|r}}
| Switch to Raw tab.
|-
| Editor
| {{k|Alt}} + {{k|m}}
| Switch to Metadata tab.

F11 is reserved by MacOS to clear the desktop.

|-
| Anywhere
| {{k|F11}}
| Toggle fullscreen.

ctrl+q hides thumbnails in the edit view; command+q quit RT but creates a prompt that the program crashed.

|-
| Anywhere
| {{k|Ctrl}} + {{k|q}}
| Quit.
|-

The following plain keys seem to work.

| Editor
| {{k|z}}
| Zoom to 100%.
|-
| Editor
| {{k|+}} or {{k|&#61;}}
| Zoom in.
|-
| Editor
| {{k|-}} or {{k|_}}
| Zoom out.
|-
| Editor
| {{k|8}}
| Background color of image preview: theme-based.
|-
| Editor
| {{k|9}}
| Background color of image preview: black.
|-
| Editor
| {{k|0}}
| Background color of image preview: white.
|-
| Editor
| {{k|<}}
| Toggle highlight clipping.
|-
| Editor
| {{k|>}}
| Toggle shadow clipping.
|-
| Editor
| {{k|Shift}} + {{k|b}}
| Before/After view.
|-
| Editor
| {{k|c}}
| Crop tool.
{{k|Shift}}+{{k|left-click-drag}} within the cropped area to move the entire crop border.
|-

Below works as ctrl key, but should be command key.

| Editor
| {{k|Ctrl}} + {{k|e}}
| Edit current image in external editor.
|-
| Editor
| {{k|Ctrl}} + {{k|s}}
| Save current image.
|-
| Save Window
| {{k|Ctrl}} + {{k|Enter}}
| "OK" to save.
|-
| Editor
| {{k|Ctrl}} + {{k|Shift}} + {{k|s}}
| Force saving current settings to the processing profile.
This happens automatically each time you close the image or RawTherapee, but you can also force it to happen immediately so you don't lose any work should the program crash.
|-
| Editor
| {{k|Ctrl}} + {{k|z}}
| Undo.
|-
| Editor
| {{k|Ctrl}} + {{k|Shift}} + {{k|z}}
| Redo.
|-

Plain key Works.

| Editor
| {{k|f}}
| Fit to screen.

Alt key does not work.

|-
| Editor
| {{k|Alt}} + {{k|f}}
| Fit cropped area to screen.
|-

Plain keys Work.

| Editor
| {{k|h}}
| Hand/cross tool (standard); use this to navigate around a zoomed image or to move the frame that defines where the detail window is.
|-
| Editor
| {{k|i}}
| Toggle quick info (Exif info overlay).
|-
| Editor
| {{k|Right-click}} in the preview area
| Return to default cursor (after having used the pipette for white balance or the straightening tool).
If the RGB indicator bar is enabled, this (un)freezes its indicators.
|-
| Editor
| {{k|s}}
| Select straight line (Rotate tool).
|-
| Editor
| {{k|Alt}} + {{k|s}}
| Add a snapshot.
|-
| Editor
| {{k|Shift}} + drag crop
| Move crop border.
|-
| Editor
| {{k|w}}
| Spot white balance pipette.
|-
| Editor
| {{k|r}}
| [[image:Preview mode 2 red.png]] Toggle [[Preview_modes | preview mode]] - red.
|-
| Editor
| {{k|g}}
| [[image:Preview mode 3 green.png]] Toggle [[Preview_modes | preview mode]] - green.
|-
| Editor
| {{k|b}}
| [[image:Preview mode 4 blue.png]] Toggle [[Preview_modes | preview mode]] - blue.
|-
| Editor
| {{k|v}}
| [[image:Preview mode 5 luminance.png]] Toggle [[Preview_modes | preview mode]] - luminosity.
|-
| Editor
| {{k|Shift}} + {{k|f}}
| [[image:Preview mode 6 focus.png]] Toggle [[Preview_modes | preview mode]] - focus mask.
|-
| Editor
| {{k|[}}
| Rotate open image left.
|-
| Editor
| {{k|]}}
| Rotate open image right.
|-
| Editor
| {{k|-}}
| Decrease preview size.
|-
| Editor
| {{k|+}}
| Increase preview size.
|-
| File Browser
| {{k|[}}
| Rotate selected thumbnail left.
|-
| File Browser
| {{k|]}}
| Rotate selected thumbnail right.
|-

Alt does not work.

| [[The_Image_Editor_Tab#The_Filmstrip | Filmstrip]] (SETM)
| {{k|Alt}} + {{k|[}}
| Rotate selected thumbnail left.
|-
| [[The_Image_Editor_Tab#The_Filmstrip | Filmstrip]] (SETM)
| {{k|Alt}} + {{k|]}}
| Rotate selected thumbnail right.
|-
| [[The_Image_Editor_Tab#The_Filmstrip | Filmstrip]] (SETM)
| {{k|Alt}} + {{k|-}}
| Decrease thumbnail size.
|-
| [[The_Image_Editor_Tab#The_Filmstrip | Filmstrip]] (SETM)
| {{k|Alt}} + {{k|+}}
| Increase thumbnail size.
|-

Plain keys work.

| File Browser
| {{k|-}}
| Decrease thumbnail size.
|-
| File Browser
| {{k|+}}
| Increase thumbnail size.
|-
| File Browser
| {{k|i}}
| Toggle thumbnail information.

...

reagle commented 6 years ago

BTW: If it would help, I'd be willing to contribute to a bounty for this.

DeziderMesko commented 6 years ago

For me, (RT 5.3) any shortcut related to filtering (rank, color labels) is not working.

And btw even I understand that new releases are useful for all platforms users, only partially functional keyboard shortcuts effectively repel all MacOS users.

mariboudev commented 4 years ago

Hi folks, First can I say a big thanks to the whole team. I love using RawTherapee and when I first began getting into photography a little more seriously it was a God send to be able to work with Raw files without having to spend big money on licenses.

I really enjoy using this software, and with the improvements you guys have been making in the last year or so it's getting better and better.

I'd love to be able to leverage RawTherapee to a fuller extent by (for example) being able to cull images in the file browser, using the rank or color group feature. However, as I'm using a Mac, and the shortcuts don't work, this job is far more time consuming.

I can see that this issue has been open for a long time, and can only surmise that fixing it must be a really big job.

Not having shortcuts is HUGE.

So if fixing is actually feasible, and if there is any way to bump this bug up the priority list, then please take my vote for this to be looked at again.

dconrad5 commented 4 years ago

As mentioned in #5790, in addition to others outlined in this issue, Command-H and Command-Option-H do not work - they simply don't do anything. There's no overlap with another function because those are the generally accepted shortcuts to hide an application/hide all other applications, but they still don't work.

nomar500 commented 1 year ago

I've closed my #6577 report as this one is more extensive; yet, I'm not sure it addresses the picture rating filter aspect of it.

So... here's what I initially filed: Some keyboard shortcuts appear to be broken on my MacOS (12.5) build of RT (dev branch 5.9)

In the File Browser, pressing the 1 key does nothing, apparently - it should toggle highlight of 1-star images
Pressing the 2 key does what's expected of the 1 key.
In the Editor, the 1 key does what the 9 key is supposed to do (switch the background colour)
The shift+ctrl+number shortcuts for colour labels don't seem to work either.
Note: changing the keyboard layout does not seem to fix this.

daturkel commented 3 months ago

I'm using 5.10 on MacOS Big Sur and also having issues with keyboard shortcuts. 1 seems to toggle the background color, as does Shift-1, 2 applies a profile though I can't tell which one. 3, 4, 5 don't seem to do anything. I'd really like to be able to use keyboard shortcuts to rank photos while browsing.

daturkel commented 3 months ago

@Beep6581 I see you've added a v6 milestone on this issue. Is work currently in development to fix it for the next version? If not, do you have an idea of where the issue is in the codebase—I'm not a C++ developer but if I could lend a hand at all, I'd love to.

Benitoite commented 3 months ago

Here's one example of gtk handling of keyboard shortcuts, here for the editor panel: https://github.com/Beep6581/RawTherapee/blob/1aefd200d83e190ad9b38ce28c3a43d2c67afeee/rtgui/editorpanel.cc#L1717

Beep6581 / RawTherapee

Some keyboard shortcuts not working in macOS #3510