Closed Beep6581 closed 9 years ago
Olli, what do you think about maximizing the GUI control where the image preview is
to full screen when spacebar is pressed? When maximized, would be helpful to support
next and previous image with the arrow keys.
Reported by michaelezra000
on 2010-12-02 18:42:32
... or generate a monitor-size thumbnail and display full screen. Actually, supporting
generation of monitor-size previews has many further benefits. For example, very quick
export of usable preview files for website use or pdf contactsheets. This is what I
currently use in Adobe Bridge. RT does not support quick export of previews today.
So this would serve more than one purpose. Preferences may have a checkbox for monitor-size
previews.
Reported by michaelezra000
on 2010-12-02 18:49:20
Michael, I think it's a total different animal than this.
With this features, I want to elegantly scan through the pictures for showing them
(way faster then loading edit windows), or I want to see how the e.g. noise reduction
(not shown in the preview) is in the final picture. Just making the preview window
larger would not serve this use case I think.
And these resize/build PDF sheets etc. features are all already implemented in other
photo viewers. It would be lots of work to implement the same feature set as e.g. the
FastStone Image Viewer already has. (maybe have a look: http://www.faststone.org/FSViewerDetail.htm
;it's very fast+stable, and has tons of features like batch resize, generating preview
PDFs with many options)
So in this case I like the idea of just integrating RT better with existing other products.
I would safe the dev work for doing more critical things like e.g. DNG/XMP metadata
integration.
Reported by oduis@hotmail.com
on 2010-12-02 19:49:13
Olli, do I understand this correctly - your new feature will allow to call an external
tool to view a corresponding and already previously batch-converted image. If such
converted image was not produced/found, there would be nothing to show.
Reported by michaelezra000
on 2010-12-02 21:26:30
Yes, and it's always the Windows standard viewer for the file format (JPG, PNG...).
As if you double clicked on it in Explorer and pressed the maximize button.
So e.g. I set FastStone as standard for JPG in Windows. On F5 it auto-opens the image
full screen, no menus etc. Its is there instantly since it does not need e.g. to process
a huge TIFF file (like in send to editor). In FastStone I can do all the fancy stuff
like fast one-click magnifying glass, comparing image versions, slideshows or whatever.
Pressing ESC closes FastStone immediately and I am back in RT where I left.
So from my point of view it's a well integrated experience, and not worth the effort
to program all this in RT.
Reported by oduis@hotmail.com
on 2010-12-02 21:40:49
I see. My concern is for this workflow: imagine I have 1000 raw files. all I want is
to quickly go through them in full screen and view with RT adjustments). Your approach
would only work if all 1000 raw files are actually batch-pre-converted at full resolution,
which would require a substantial computer time...
Actually!!!! I see a good solution here for both scenarios! what if RT is enabled to
generate processed previews in /previews directory (at user-selected resolution) very
quickly. Then your approach would target those images. It is then upto a user, if those
images are full resolution, monitor size of whatever.
hmm It seems that it would be nice in your approach to provide and override to a subdirectiry
name. For example, I would use /previews for quick viewing and /converted for 100%
perfect full conversion. The /converted is in batch RT settings already, so it would
be cool to allow user define this path for "F5" key!
I would actually really love this solution, as i tend to generate and archive monitor
size previews along with raw files. And having ability to call them up from the RT
itself is nice. The only problem of course would be that if RT adjustments are changed
for particular image, preview in /previews is not auto-updated.
Reported by michaelezra000
on 2010-12-02 21:55:58
how about F5 for batch-queue based path and Shift-F5 for /previews ;)
Reported by michaelezra000
on 2010-12-02 22:05:14
I now understand your workflow, but I think it would not be trivial to integrate it
in RT. There would have to be a parallel preview processing with simple demosaic and
fast resize for 1000+ pictures, with seperate paths and settings etc.
Sure it's doable, but it would be a lots of work.
Reported by oduis@hotmail.com
on 2010-12-02 22:10:47
I actually thought it may be much simpler. There is already code which can generate
correct thumbnails. If thumbnails are monitor-size (user-defined) and could be viewed
full screen - thats all I would need:) thats why I suggested to use RT's internal resource
to show them, as thumbnails are not necessarily jpg - RT also has its own format which
is not understood by other software.
Reported by michaelezra000
on 2010-12-02 22:29:09
I think a full-screen fast preview is extremely important: not only for slideshow or
whatever demonstrative stuff, but for opening and reviewing images fast (judging sharpness,
focus, etc.). The fast demosaic approach is good, but not responsive enough even on
newer machines.
Full-screen preview + metadata panel in a tab. That's my vision. :)
Reported by gyurko.david@e-arc.hu
on 2010-12-02 23:26:24
I understood your wishes, but as pointed out, that would be a third batchable pipeline,
a mixture between thumbs and full processing. But that's not done in 5 minutes ;-)
If you get another developer to program that preview pipeline, I'll add the proposed
Shift-F5 to this feature for you.
Reported by oduis@hotmail.com
on 2010-12-03 07:15:00
:)
Reported by michaelezra000
on 2010-12-03 13:55:14
Committed
Reported by oduis@hotmail.com
on 2010-12-03 18:24:21
Fixed
A little addition: Pressing SHIFT-F5 will now open the containing directory in Explorer.
If Explorer was already open with this dir, it will not open another one but bring
the existing one to front.
Reported by oduis@hotmail.com
on 2010-12-03 19:52:15
PatchSubmitted
Shift-F5 opens explorer in batch-output path E.g. "/converted" not the file's actual
path. Would it be possible to also have the file selected in the opened explorer window?
its always, you get a luxury car, now you want options:)
Reported by michaelezra000
on 2010-12-03 20:25:17
Oh man - how about Ctrl F5 opening RAW base dir?
Reported by oduis@hotmail.com
on 2010-12-03 20:32:29
that would work
Reported by michaelezra000
on 2010-12-03 20:41:33
Ok, here is the F5 deluxe edition for you ;-)
Reported by oduis@hotmail.com
on 2010-12-03 20:59:24
just found this: http://support.microsoft.com/kb/130510
/select,<sub object>: Specifies the folder to receive the initial
focus. If "/select" is used, the parent folder
is opened and the specified object is selected.
ill try deluxe now:)
Reported by michaelezra000
on 2010-12-03 21:01:57
shift-F5 and Ctrl-F5 both work
Reported by michaelezra000
on 2010-12-03 21:24:25
Oh man... here is the ultimate edition. If selects the file, and if the file is not
there, it explores the directory in general.
Reported by oduis@hotmail.com
on 2010-12-03 21:50:27
this is one perfect edition, man! Thanks:)
Reported by michaelezra000
on 2010-12-03 23:05:33
Had a tiny memleak unfortunately, but fixed it before checkin.
Great teamwork by the way :-)
Reported by oduis@hotmail.com
on 2010-12-04 05:48:59
Fixed
good catch!
I have a question for you - earlier made a patch for issue 357 http://code.google.com/p/rawtherapee/issues/detail?id=367
which was a small change for /rtgui/thumbnail.cc
Now that your patch also modified this file, should I redo that patch (as line numbers
may have been changed)? I am still new to these dev tools:)
Reported by michaelezra000
on 2010-12-04 12:00:38
Should be no problem for HG, since it was not the same part of the file.
Shall I check the other one in for You?
Reported by oduis@hotmail.com
on 2010-12-04 20:00:12
That's nice if hg can handle it. Would be great if you can check in.
I find it very useful to see focal length in caption.
Reported by michaelezra000
on 2010-12-04 20:19:22
Unfortunately HG could not merge it, but since it was just one line changed I committed
it manually (should work).
Reported by oduis@hotmail.com
on 2010-12-04 20:30:43
Originally reported on Google Code with ID 372
Reported by
oduis@hotmail.com
on 2010-12-02 17:27:18