Guide overlays for Perspective and Distortion

[Beep6581]

Originally reported on Google Code with ID 387

Dashed Guide Lines (mesh of squares) overlayed on the preview image would be very helpful
to apply Perspective and Distortion corrections. 

Reported by michaelezra000 on 2010-12-06 04:48:48

[Beep6581]

Useful, I'll take this.

Reported by oduis@hotmail.com on 2010-12-06 13:13:39

• Status changed: Started
• Labels added: Type-Enhancement
• Labels removed: Type-Defect

[Beep6581]

Here is the new feature. Would be great if someone could test it.

Reported by oduis@hotmail.com on 2010-12-06 17:24:20

• Status changed: PatchSubmitted

[Beep6581]

That was quick:) it works!

I guess activation is only when crop is enabled. Probably not 100% intuitive, but it
works.
Should this be named "Square Mesh"? Checker board usually is associated with alternating
black and white squares.

Reported by michaelezra000 on 2010-12-06 17:48:44

[Beep6581]

You're the native speaker, so here is the updated patch...

Reported by oduis@hotmail.com on 2010-12-06 17:56:11

[Beep6581]

My native language is Russian:) I am from former USSR

Reported by michaelezra000 on 2010-12-06 18:07:16

[Beep6581]

Haven't had time to test the patch yet, but concerning naming, I think "grid" is quite
common for this type of feature. It's called grid in Gimp and in Bibble's perspector
tool for example.

Reported by torger@ludd.ltu.se on 2010-12-06 18:12:07

[Beep6581]

Ok, "Grid" then. I hope this is final now ;-)

Reported by oduis@hotmail.com on 2010-12-06 18:27:52

---

• Attachment: Grid.patch

[Beep6581]

lol:) do you think it should be "Grid 10" :)
these cosmetic change - that's what can kill you!:)

Reported by michaelezra000 on 2010-12-06 18:39:00

[Beep6581]

Works for me. Could you add a slider with which we could smoothly adjust the distance
between grid lines? To be used for positioning one of the grid lines parallel to a
building edge, for example.

Reported by entertheyoni on 2010-12-06 18:51:30

[Beep6581]

this may not as straight-forward with current approach...
with slider this should be a checkbox "Display Grid" with underlying slider for distance
between the grid lines, all posisioned under lens geometry.
that would be a larger change of course

Reported by michaelezra000 on 2010-12-06 19:15:40

[Beep6581]

The grid density slider exists in the zperspector plugin for Bibble. However, I have
myself not really seen the need for adjusting the density, what you want is just like
you say position the grid just at a building edge, but then it would be better to just
move the grid start offset with the slider than adjusting density, since it is harder
to view with a really dense grid. You could have two sliders of course though... but
then perhaps one makes the tool more complex than it really should be.

So far I have used the crop tool as guideline :-), temporarily setting the crop parallel
to a building edge and adjusting perspective/lens etc until it matches. A grid is a
great improvement.

(For my uses, an ideal guideline tool would be to be able to draw custom straight-line
guidelines where the endpoints get locked to the picture pixel positions, so when the
pixels move around due to transformation of the picture, the guideline move too. I
would then draw a guideline on the building edges and adjust perspective until it looks
fine. Such guideline drawing could also help see bending of lines that are not vertical
and horizontal. I also think perspective and rotate GUI could be unified and helped
by this guideline thing, looking at picture orientation more as Hugin does... but now
I'm babbling :-) ).

Reported by torger@ludd.ltu.se on 2010-12-06 19:50:47

[Beep6581]

Sorry guys, that may all be cool but too much work. This patch is my offer. Someone
else may add more features if desired.

Reported by oduis@hotmail.com on 2010-12-06 20:03:16

[Beep6581]

Olli, you patch will definitely do as version 1,0
This will simplify lens distortion calibration and general use of perspective and distortion.
May be before checkin you could add a comment with reference to this thread for ideas
for further improvements.

Thanks a lot for such quick patch, I just opened this issue last night!

Reported by michaelezra000 on 2010-12-06 20:17:08

[Beep6581]

Thanks, just committed and set a reference to this thread.

Reported by oduis@hotmail.com on 2010-12-06 20:29:18

• Status changed: Fixed