search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.9k stars 323 forks source link

Raw crop #4263

Open heckflosse opened 6 years ago

heckflosse commented 6 years ago

A while ago I created the rawcrop branch, which allows to define a raw crop in pp3 instead of camconst.json

The engine part should be ready, but we need a gui for it.

The raw crop will be applied at decoding the raw file. That means, once it's applied, we won't have access to the parts outside the raw crop. This reduces memory usage and processing time for further steps (preprocessing, demosaic and so on) but also makes a gui a bit difficult. For example, assume you already rotated your image and made perspective correction, and then decide to make a raw crop. In this case the image has to be displayed without rotation and perspective correction to define the raw crop in gui.

Please share your thoughts

Hombre57 commented 6 years ago

I'll try to do that GUI with a button for on preview adjustment, just like the Gradient tool. The pipeline will be truncated so that it'll decode and get the raw image without any transformation and skip everything else !

Assigning this issue to myself (if you're okay), but will remove it if unsuccessful.

Hombre57 commented 6 years ago

@heckflosse @Beep6581 Only 4 spin buttons for X, Y, Width and Height, + a button for on preview adjustment will be enough ? (no aspect ratio, ppi, etc...)

heckflosse commented 6 years ago

@Hombre57 yes, only x, y, w and h

Hombre57 commented 6 years ago

@heckflosse I'm busy with the Exif.UserComment (issue #2017) issue right now, but I've already started the patch for the GUI we're talking about here. Just wanted to let you know... Expect one week before any news.

heckflosse commented 6 years ago

Expect one week before any news.

No need to hurry!

Hombre57 commented 6 years ago

WARNING : commit 0db576ad589ace6f9626b7929a4b3989d7dc3d83 has been mistakenly pushed. It's still work in progress, don't look for bugs or nitpicking on coding style. Thanks, and sorry for the inconvenience.

Hombre57 commented 6 years ago

@heckflosse I thought again at what we discussed on IRC about desired image orientation while using the On Preview widgets. I think it's best to use the shot's orientation, not the sensor one (landscape). I think that users will find it awkward to adjust the crop on a shot taken in portrait mode (e.g.). The pp3 should then refer to the GUI values, which will be in shot's orientation.

Could you update the engine part to convert from shot's orientation to sensor orientation before I go further ?

@Beep6581 @agriggio @Floessie & all : you're welcome to give your opinion on this.

Hombre57 commented 5 years ago

Just for the record, if this feature is not abandonware, I took some of the changes done in the raw-crop branch and added it (modified) in spot-removal, so it should only be resumed after spot-removal is committed.

heckflosse commented 5 years ago

@Hombre57 Imho we should rework raw-crop from scratch.

Hombre57 commented 5 years ago

@heckflosse Was there a problem on the GUI side ?

heckflosse commented 5 years ago

@Hombre57 I don't remember. But as it's very long ago it may be better to rework it from scratch than to adapt it to current dev

Hombre57 commented 5 years ago

@heckflosse Okay, but don't delete this branch yet, I might need it for "inspiration" :wink:

heckflosse commented 5 years ago

ok