Beep6581
commented
6 years ago Hello @aferrero2707
- The AppImage was updated correctly.
- I totally missed that the Zenity dialog showed the download destination - I looked only in the console output and could not find where the AppImage was saved. Would be nice if the console output made that clear as well.
- The console output mentions some
download_release.shscript which does not exist. - The download progress gets lost in the sea of other output. Separating it from the rest with a blank line before and after would be good.
Patch for the above:
diff --git a/AppRun b/AppRun
index 1828ed7..757f7d8 100755
--- a/AppRun
+++ b/AppRun
@@ -39,10 +39,15 @@ if [ "x" = "x" ]; then
"$APPDIR/usr/bin/zenity.sh" --question --text "New version available:\n\nhttps://github.com/${REPO_SLUG}/releases/${RELEASE_TAG}/${AI}\n\nDo you want to download and run it?\nThe new package will be stored in $HOME/.local/appimages"
ANSWER=$?
if [ x"$ANSWER" = "x0" ]; then
- echo "./download_release.sh \"$REPO_SLUG\" \"$AI\" \"$ID\""
- mkdir -p "$HOME/.local/appimages"
+ mkdir -p "$HOME/.local/appimages" | exit 1
asset_url="https://api.github.com/repos/$REPO_SLUG/releases/assets/$ID"
+ printf '%s\n' "" \
+ "Downloading latest RawTherapee AppImage" \
+ " From: ${asset_url}" \
+ " To: $HOME/.local/appimages/$AI" \
+ "Progress:"
curl -XGET -o "$HOME/.local/appimages/$AI" --location --header "Accept: application/octet-stream" "${asset_url}"
+ printf '\n'
chmod u+x "$HOME/.local/appimages/$AI"
"$HOME/.local/appimages/$AI"
exit
aferrero2707
heckflosse
fliker09
Dear all, I have just finished setting up a GitHub repository to automate the building and packaging of RT for Linux (in AppImage format) and Windows 64-bit (cross-compiled with mingw-w64). The build process is based on Travis CI, and uses custom Docker containers that provide the required dependencies. The packages are automatically uploaded back to GitHub.
At the moment the building is limited to the
devRT branch, but other branches (likereleasesandnewlocallab) can be easily added. The build process can be triggered by hand or run regularly (daily or weekly) using cron jobs.It should also be possible to include OSX packages in the automated building process.
The advantage of this approach is that each build is executed in a well-defined and encapsulated environment, and is perfectly reproducible. Moreover, any user that is added as a collaborator to the github repository should also be able to trigger new builds on Travis, without the need of having a windows system at hand...
First of all, and before doing further developments of the build environment, I'd like to know if the RT developers are interested in this possibility. Of course I'm open to any suggestion and remark!