Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.83k stars 320 forks source link

Clipped highlights look posterized #4479

Open TooWaBoo opened 6 years ago

TooWaBoo commented 6 years ago

Images taken with my pocket cam Nikon P330 and clipped highlights look posterized and washed out. In the past it looked fine, but with the latest version of RT it doesn't. I can't tell when this issue appeared the first time.

Link to RAW and pp3 https://filebin.net/qxlzm3k1w6g087je

grafik

Version: 5.4-122-gf9396f2a
Branch: dev
Commit: f9396f2a
Commit date: 2018-03-29
Compiler: gcc 7.3.0
Processor: undefined
System: Windows
Bit depth: 64 bits
Gtkmm: V3.22.0
Lensfun: V0.3.2.0
Build type: release
Build flags: -mwin32 -m64 -mthreads -msse2 -std=c++11 -march=native -Werror=unused-label -fopenmp -Werror=unknown-pragmas -Wall -Wno-unused-result -Wno-deprecated-declarations -Wno-aggressive-loop-optimizations -DNDEBUG -O3 -ftree-vectorize
Link flags: -m64 -mthreads -static-libgcc -fno-use-linker-plugin -march=native -s -O3
OpenMP support: ON
MMAP support: ON
TooWaBoo commented 6 years ago

Another example with "Color propagation"

Highlight compression = 0 1

dev Highlight compression = 150 3

5.4 Highlight compression = 150 2

Floessie commented 6 years ago

I must admit, I had to go back to 5.4 for a job recently due to the problems with current HLR. So I'm very pleased that @TooWaBoo keeps on bothering and Alberto keeps on optimizing. Whether the whole thing is worth it, I don't know, as the benefits discussed on pixls weren't immediately obvious to me. But I'm no expert here, just a user...

@agriggio @TooWaBoo Please continue to struggle for a solution, that fits best for the casual user and the math-inclined expert. :+1:

JM2¢, Flössie

agriggio commented 6 years ago

I'm working on a solution

agriggio commented 6 years ago

Here you go:

screenshot from 2018-04-05 14 00 14

I hope this makes everyone happy :-) (this is already in dev, btw)

Beep6581 commented 6 years ago

I like to hover the mouse over a widget and click it to see what changes, which could take a few seconds, then click again to change back, eyes on the preview the whole time. Large tooltips get in the way, obscure and distract. Issue #2221, which nobody responded to, is about moving them away from active widget elements and moving them onto labels where you wouldn't normally statically hover the cursor, and about moving unnecessary tooltips into RawPedia where they are easier to maintain, translate and demonstrate with images. Furthermore, I believe we should use tooltips only for information which is needed to be seen many times, not information which one needs to read only once. For example, hovering over a history panel item shows a tooltip with the whole history message, which is useful since the history panel is narrow and often a row will be truncated as it doesn't fit within the panel. On the other hand, hovering over "Auto Levels" tells you nothing you need to see more than once, and it's a large and intrusive tooltip.

@agriggio would you mind removing that tooltip and putting the info into RawPedia?

agriggio commented 6 years ago

@Beep6581 sure, no problem. I wasn't even aware that #2221 existed, otherwise I wouldn't have added the tooltip in the first place...

TooWaBoo commented 6 years ago

@agriggio

Thanks for adding the checkbox. I'm happy now. ... but the checkbox has no effect. It doesn't switch between the two modes.

Version: 5.4-144-g7328fa92
Branch: dev
Commit: 7328fa92
Commit date: 2018-04-05
Compiler: gcc 7.3.0
Processor: undefined
System: Windows
Bit depth: 64 bits
Gtkmm: V3.22.0
Lensfun: V0.3.2.0
Build type: release
Build flags: -mwin32 -m64 -mthreads -msse2 -std=c++11 -march=native -Werror=unused-label -fopenmp -Werror=unknown-pragmas -Wall -Wno-unused-result -Wno-deprecated-declarations -Wno-aggressive-loop-optimizations -DNDEBUG -O3 -ftree-vectorize
Link flags: -m64 -mthreads -static-libgcc -march=native -s -O3
OpenMP support: ON
MMAP support: ON