search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.82k stars 319 forks source link

Supersede "default processing profile for" with dynamic profiles #4488

Open Beep6581 opened 6 years ago

Beep6581 commented 6 years ago

Now that RawTherapee has the ability to dynamically apply profiles based on rules, I think we should remove "Default processing profile for (non-)raw photos" and use dynamic profile rules instead.

Attached is a draft of new rules which RT could ship by default. dynamicprofile.cfg.txt

Beep6581 commented 6 years ago

There is a difficulty in shipping default rules which the user should be able to change or delete, as our CMake files are currently unaware of the path to the user's options file.

There are at least two possible paths for the options file: one uses the RT_SETTINGS environment variable, the other looks in g_get_user_config_dir/CSIDL_LOCAL_APPDATA.

rtdata/options/options.lin, for example, gets installed into DATADIR which could be read-only, but the user can overwrite the keys in that file by creating the same keys with different values in the user's options file. If we ship dynamicprofile.cfg the way we ship rtdata/options/options.*, and if the file includes 7 rules by default, named rule 1 to rule 7, how would the user delete these rules?

Maybe @agriggio @Hombre57 have an idea?

agriggio commented 6 years ago

note that currently dynamic profile rules lack a way to distinguish raw from non-raw images. this would be needed if we want to replace the default mechanism