Closed gaaned92 closed 6 years ago
@gaaned92 is this Windows 10?
5.4-383-g168309f45 works fine on win7
@Beep6581 yes on W10
@heckflosse Is it a build from you? or from me ? As I rebuilt lensfun master branch, there is perhaps a problem with it?
@gaaned92
As I rebuilt lensfun master branch, there is perhaps a problem with it?
Does it always hang during lensfun DB loading?
@gaaned92 my own build
@gaaned92 Have you tried the Windows 7 Compatibility Mode?
@heckflosse do you build lensfun yourself? or do you use the old msys2 lensfun lib?
@Floessie It reads the bundled PP3 and DCP. No lensfun message
So seems I have to revert lensfun master but to what commit?
@gaaned92
So seems I have to revert lensfun master but to what commit?
I wouldn't conclude it's lensfun's fault from what I've read so far in this issue. There's still Win7 vs. Win10 and your build vs. Ingo's build.
I was just asking whether it always hangs when reading the lensfun DB, because in #4580 we found out that the lensfun API isn't thread-safe.
@gaaned92 I use the old msys2 lensfun lib
@Floessie 5.4-342-g6adc09071 runs ok with old lensfun build but It stops with new lensfun build.
Then following @Benitoite advice, I opened rawtherapee.exe property window
, then compatibility
then solve compatibility problem
.
W10 set up Windows 8 compatibility mode then program slowly starts.
Nevertheless trying to revert lensfun.
I don't know if it help, but I've just compiled nightly-187-g168309f45 on my w10 and it has no problems with start.
Version: nightly-187-g168309f45 Branch: dev Commit: 168309f45 Commit date: 2018-06-12 Compiler: gcc 7.2.0 Processor: undefined System: Windows Bit depth: 64 bits Gtkmm: V3.22.0 Lensfun: V0.3.2.0 Build type: release Build flags: -std=c++11 -march=native -Werror=unused-label -fopenmp -Werror=unknown-pragmas -Wall -Wno-unused-result -Wno-deprecated-declarations -O3 -DNDEBUG -ftree-vectorize Link flags: -march=native OpenMP support: ON MMAP support: ON
@Kildor there is an error in your repo, see this to fix it: https://github.com/Beep6581/RawTherapee/issues/4509#issuecomment-382731056 or delete your repo and clone again.
@Beep6581, thank you.
Version: 5.4-383-g168309f45 Branch: dev Commit: 168309f45 Commit date: 2018-06-12 Compiler: gcc 7.2.0 Processor: undefined System: Windows Bit depth: 64 bits Gtkmm: V3.22.0 Lensfun: V0.3.2.0 Build type: release Build flags: -std=c++11 -march=native -Werror=unused-label -fopenmp -Werror=unknown-pragmas -Wall -Wno-unused-result -Wno-deprecated-declarations -O3 -DNDEBUG -ftree-vectorize Link flags: -march=native OpenMP support: ON MMAP support: ON
Definitly a problem with Lensfun master branch. Using master commit 781e56ca96, RT aborts unless you change compatibility to Windows 8. Using master commit 2a186cb1e, RT starts ok.
https://sourceforge.net/p/lensfun/code/ci/f4327669dd8bfc3b1b1214ae6c0460d9a2889775/ https://sourceforge.net/p/lensfun/code/ci/9c0b03bfde63b50371cbb917b54c965cd27afb2a/ Behind these commits is new API breaking code. @agriggio & other lensfun-knowledgeable people, lensfun is apparently going to release an alpha version tag in the near future. https://sourceforge.net/p/lensfun/code/ci/781e56ca96dcec82a69e38597b609a207af03e27/ https://sourceforge.net/p/lensfun/wiki/Release%20schedule/
@heckflosse @agriggio @Benitoite Do I close this thread as it seems we have to wait for the new version?
🤙 @gaaned92 you might like to edit the title to reflect the issue with lensfun 🤔
RT should support the latest-stable lensfun release, regardless how old, because most distros won't ship an alpha version of lensfun.
Yes , sure for RT stable version . Nevertheless, there could be some branch supporting new lensfun development.
As noticed here https://discuss.pixls.us/t/rawtherapee-dev-5-4-374-g83e686a71-winvista-64-doesnt-start/8014, Rawtherapee suddenly stops during initialisation when starting directly by double clicking or in a mingw shell for each start, it doesn't stop at the same place.
It starts ok with gdb.(no warning)