SETM Filmstrip height wrong when using Filmstrip toolbar

[heckflosse]

To reproduce

1. Make sure filmstrip and toolbar are visible.
2. Hide top panel.
3. Close RT
4. Open RT and goto Editor tab
5. Show top panel.
6. A buggy vertical scrollbar is visible on the right - the filmstrip is not tall enough to accomodate both thumbs and toolbar.
7. Press t, the toolbar hides.
8. Press t again, the toolbar appears, and this time the filmstrip is vertically resized.

[TooWaBoo]

Works fine with the TooWaBlue theme but file names etc are not shown in the filmstrip when activated in preferences.

[heckflosse]

@TooWaBoo

Works fine with the TooWaBlue theme

I disagree:

[TooWaBoo]

Can't reproduce on Win10

[heckflosse]

@TooWaBoo Filenames are shown when info button is enabled

[TooWaBoo]

Tried several times with the RT- and TWB-theme. I can reproduce the bug with the RT- but not with the TWB-theme. I do not know why it behaves differently.

Argh, forgot the info button. :-)

[TooWaBoo]

Found the culprit at line 150 of the RT-theme.

#FileBrowser {
-->    padding: 2px; should be padding: 0px
       margin: 0px;
}

To get a 2px border at the top, add this:

#MainNotebook > stack {
    padding-top: 2px;
}

To remove 2 pixel from the top of the histogram (this has now a border of 4 pixel) change this at line 493

#HistogramPanel {
--> margin: 0 change to margin: -2px 0 0;
    padding: 0;
}

[heckflosse]

@TooWaBoo Can you post a patch please? I've tried with this one and it does not work:

diff --git a/rtdata/themes/RawTherapee-GTK3-20_.css b/rtdata/themes/RawTherapee-GTK3-20_.css
index 3f25ce509..df387f838 100644
--- a/rtdata/themes/RawTherapee-GTK3-20_.css
+++ b/rtdata/themes/RawTherapee-GTK3-20_.css
@@ -923,6 +923,10 @@ paned > separator {
     margin: 0;
 }

+#MainNotebook > stack {
+    padding-top: 2px;
+}
+
 #RightNotebook #ToolPanelNotebook stack {
     margin: 0px;
 }

[TooWaBoo]

@heckflosse RawTherapee-GTK3-20_.css.txt

[TooWaBoo]

@heckflosse Did you test the theme? Does it work?

[heckflosse]

@TooWaBoo Sorry for late reply. I tested but it's still the same.

[TooWaBoo]

Hmmm, if padding is not 0 I can reproduce the bug in RT and TWB. If padding is 0 both themes work fine. I've no idea why.

#FileBrowser {
-->    padding: 2px; should be padding: 0px
       margin: 0px;
}

[TooWaBoo]

@gaaned92 is on Win10 too, perhaps he can test too.

[TooWaBoo]

@heckflosse Looks like this is fixed. Issue can be closed