Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.9k stars 323 forks source link

Hardcoded dcraw overrides -> camconst.json? #4887

Open Thanatomanic opened 6 years ago

Thanatomanic commented 6 years ago

In rtengine/rawimage.cc there is a bunch of overrides for specific camera models. Instead of hardcoding them, wouldn't it make more sense to move these to camconst.json?

https://github.com/Beep6581/RawTherapee/blob/dev/rtengine/rawimage.cc#L818

iliasg commented 6 years ago

Most of these are already in camconst.json .. just forgot to clean up rawimage.cc .. let me some days to check again some details and then clean up ;)