Suppression of hard coded english words and addition of new translated items (new modifications)

[Beep6581]

Originally reported on Google Code with ID 58

Hi,

This patch includes modifications in issue 52 and 57 and also includes
additional improvments.
Cheers,

Philippe

Reported by google@hupe.me on 2010-03-04 21:54:09

---

• Attachment: rawtherapee-translation.diff

[Beep6581]

Philippe, well done!

Here are some more hard-coded strings. Can you add this to your diff-file, as I don't
know for now how to create patches (although I can apply them, like yours). 

Cordialement/Cheers,
Paul. 

rtgui/zoompanel.cc, lines 77+:
zoomIn->set_tooltip_text ("Zoom In");
zoomOut->set_tooltip_text ("Zoom Out");
zoom11->set_tooltip_text ("Zoom to 100%");
zoomFit->set_tooltip_text ("Fit to screen");
newCrop->set_tooltip_text ("Add new crop window");

rtgui/editorpanel.cc:
71: beforeAfter = Gtk::manage (new Gtk::ToggleButton ("B|A"));
72: beforeAfter->set_tooltip_text ("Toggle before/after view");
132: queueimg = Gtk::manage (new Gtk::Button ("Put to queue"));

rtgui/filepanel.cc:
84: Gtk::Label* devLab = new Gtk::Label ("Develop");
86: Gtk::Label* filtLab = new Gtk::Label ("Filter");
88: Gtk::Label* tagLab = new Gtk::Label ("Tagging");

rtgui/navigator.cc:
23: set_label ("Navigator");
55: position->set_text ("x = n/a, y = n/a");
56: R->set_text ("R = n/a");
57: G->set_text ("G = n/a");
58: B->set_text ("B = n/a");
59: H->set_text ("H = n/a");
60: S->set_text ("S = n/a");
61: V->set_text ("V = n/a");

rtgui/colordenoise:
32: amount = Gtk::manage (new Adjuster ("Amount", 1, 100, 1, 30));

rtgui/resize.cc:
46: spec->append_text ("Scale");
47: spec->append_text ("Width");
48: spec->append_text ("Height");
51: combos->attach (*Gtk::manage (new Gtk::Label ("Specify:")), 0, 1, 1, 2,
Gtk::SHRINK, Gtk::SHRINK, 2, 2);

rtgui/preferences.cc:
78: nb->append_page (*getBatchProcPanel(),      "Batch Processing");
93: Gtk::Frame* behFrame = Gtk::manage (new Gtk::Frame ("Behavior"));
103: behTreeView->append_column ("Property", behavColumns.label); 
104: behTreeView->append_column_editable ("ADD", behavColumns.badd); 
105: behTreeView->append_column_editable ("SET", behavColumns.bset); 
502: edFileNames = new Gtk::CheckButton ("Overlay filenames on thumbnails");

Reported by paul.matthijsse4 on 2010-03-05 14:05:16

[Beep6581]

Hi Paul,

Thank you for pointing out that hard coded words still remain.
I will take in charge what you have listed as soon as my previous modifications are
integrated in the svn repository.
I have send my svn diff to patches@rawtherapee.com but no news for the moment.

I would really appreciate feedback from the developers at this point just to be sure
that our modifications could be taken into account.

Cheers,

Philippe  

Reported by google@hupe.me on 2010-03-06 14:36:38

[Beep6581]

Hello Philippe, 

Gabor seems to be busy at the moment, just be patient. 

Just one more little 'typo' in rtgui/rtwindow.cc, line 32:
'Raw Therapee' must be 'RawTherapee', without a space. (This is the string in the
titlebar of RT, one can at least write the name of the program correct, isn't it? :-)

Regards, Paul. 

Reported by paul.matthijsse4 on 2010-03-07 13:45:56

[Beep6581]

OK, I have applied this patch against head.  Due to many file changes between the
time this patch was generated and today, I needed to apply most of the fixes manually
as patching failed.  Can you please take a look at this and verify that it is indeed
working as you originally desired?

In the future this should be easier, as I will try to apply patches shortly after
they are submitted, so the base code is not so far out of date.

Cheers

Reported by wyatt.olson on 2010-04-24 16:57:51

• Status changed: Fixed

[Beep6581]

Hello Wyatt, something wrong here as I can only select seven languages instead of way
more (with latest update, as of this morning). No Dutch, so I can't check if this
patch works or not. 

Regards, Paul. 

Reported by paul.matthijsse4 on 2010-04-26 08:25:08

[Beep6581]

Update: the folder ~/rawtherapee/release/languages contains only seven languages
instead of the 20+ 
Ubunto 10.04b 32-bit

Reported by paul.matthijsse4 on 2010-04-26 09:31:05

[Beep6581]

Have you tried pulling (very) recently?  I had noticed that the rtdate/CMakeLists.txt
file only included a few of the languages; I fixed this yesterday (I think).  Try a
hg pull / hg update and see if that fixes it.

Reported by wyatt.olson on 2010-04-26 13:56:06

[Beep6581]

I pulled this morning around 10 am and this afternoon again (after reading your msg)
at 4 pm. Still 7 languages available... 

Reported by paul.matthijsse4 on 2010-04-26 14:01:23

[Beep6581]

Hmm... you would probably also have to delete CMakeCache.txt and re-run 'cmake .' to
re-generate the Makefiles.  Did you try that?

Reported by wyatt.olson on 2010-04-26 14:03:05

[Beep6581]

I removed CMakeCache.txt and did a:

cmake -DCMAKE_INSTALL_PREFIX=./release -DBINDIR=. -DDATADIR=. -DLIBDIR=. && make install

still 7 languages available.

Reported by paul.matthijsse4 on 2010-04-26 14:08:24

[Beep6581]

Well this is really odd... it is working fine for me (on OSX, granted).  I removed
release/ and CMakeCache.txt, and re-ran both the entire command you did (including
the prefix and stuff) as well as just cmake without env variables, and both work fine.

Can you please verify that a) there are the correct number of languages in
rtdata/languages (should be 27) b) that rtdata/CMakeLists.txt includes all 27
languages (should be starting on line 8).  c) What 7 languages are included in
release for you?  d) Can you attach directory listing of rtdata/languages here, I
want to make sure that the capitalizations are all correct, that could also cause
problems.

Thanks

Reported by wyatt.olson on 2010-04-26 14:56:04

[Beep6581]

I did not remove /release (shouldn't be necessary, isn't it?), only CMakeCache.txt.

a. ~/rawtherapee/rtdata/languages contains 7 items
b. rtdata/CMakeLists.txt shows 7 languages (the same)
c. set (LANGUAGEFILES 
    "languages/Chinese (Simplified)"
    "languages/Chinese (Traditional)"
    "languages/English (UK)"
    "languages/English (US)"
    "languages/Norsk BM"
    "languages/Polish (Latin Characters)"
    "languages/Portugues (Brasil)")
   set (THEMEDIR "themes")
d. ls of rtdata/languages:
Chinese (Simplified)
Chinese (Traditional)
English (UK)
English (US)
Norsk BM
Polish (Latin Characters)
Portugues (Brasil)

Hey, perhaps this is about capitalisation, I remember the Dutch language file was
called 'nederlands', while the correct Dutch word is 'Nederlands'. 

I also see now that the older ~/rawtherapee-read-only/rtdata/languages contains these
same 7 languages, while the now obsolete RawTherapee-Fork/rtdata/languages contains
27 languages (all capitalized). The older but stable v2.4.1/languages shows 25
languages, all 'uncapitalized'. 

Reported by paul.matthijsse4 on 2010-04-26 15:35:41

[Beep6581]

OK it looks like something is not working on your updates... there should be 27
languages in rtdata/languages and that many languages specified in CMakeList.txt

I have just committed a change to rtdata/CMakeLists.txt; now, instead of listing each
language explicitly, we just glob them all.  (The reason we did not do that before
was that .svn folders messed up the build script; that is no longer an issue).

As a test, can you please try the following:

1) hg pull; hg update (just to be sure things are current; hopefully this will get
the change I committed 2 minutes ago to rtdata/CMakeLists.txt)
2) Checkout a new copy of head: cd ..; hg clone
https://rawtherapee.googlecode.com/hg/ rawtherapee.test
3) Compare the two.  If the rawtherapee.test has 27 languages and builds properly,
then there must be something wrong with your mercurial repository (no idea what could
be happening there... I have only been using Mercurial for a week now, but it has
been very well behaved so far)

Let me know what happens... 

Cheers

Reported by wyatt.olson on 2010-04-26 15:44:37

[Beep6581]

[quote]Hey, perhaps this is about capitalisation, I remember the Dutch language file
was called 'nederlands', while the correct Dutch word is 'Nederlands'. [/quote]

That's what I am thinking; the only 7 languages which are left are the ones which
changed more than just capitalization; for instance "English (US)" used to be called
"english_us".  When I firt made the change I had some problems with people not
re-checking out the files properly, but I did a two-step rename and it appeared to
work.  Not sure why it is breaking now...

Reported by wyatt.olson on 2010-04-26 15:46:58

[Beep6581]

test:
1. $ hg pull; hg update
2. $ cd ..; hg clone https://rawtherapee.googlecode.com/hg/ rawtherapee.test
3. rawtherapee.test/rtdata/languages contains 27 languages
4. builds properly, cd'ing to release/ and ./rt works (and I can choose Dutch!). 

Perhaps something wrong with mercurial, I'm also new to that (couple of days). 

Other problem, when I doubleclick rt in release/, the following window appears (see
attachment). I have seen this one the days before when doubleclicking rt, or making
a
shortcut to my desktop, no idea why. 

Reported by paul.matthijsse4 on 2010-04-26 16:11:48

---

• Attachment: RawTherapeev3.0alpha1.png
  

[Beep6581]

That looks like the working directory is not set correctly; from what I can tell, rt
requires that it be ran with the CWD set to where rt executable is.  If you run from
the console (i.e., 'cd release; ./rt') it should work, right?

I know that previously there was an rtstart script which set CWD among other things;
I noticed that it is no longer in the repository.  I wonder if it was deleted on
purpose b/c it was no longer needed, or if it was deleted my mistake when someone was
cleaning other things up.  Assuming launching from release works for you, I'll look
through previous versions and see if I can restore it; I am assuming that it is still
required.

Reported by wyatt.olson on 2010-04-26 16:16:05

[Beep6581]

./rt from console works okay. 
don't know why rtstart isn't any longer with us (never understood what it did, better
said, I'm more interested in developing raws, if that works, everything is okay :-)

Reported by paul.matthijsse4 on 2010-04-26 16:34:10

[Beep6581]

I have re-added rtstart to the root directory; however I am not sure what needs to be
done to get it installed to the correct folder, nor under what situations it should
be used (I assume it is applicable on all linux installs, but I am not sure).  Could
you open a new ticket with the screenshot and discussion from what happens without
rtstart, and ask a linux dev to take a look at it?

Thanks

Reported by wyatt.olson on 2010-04-26 16:55:04

[Beep6581]

Hello, I'll do that later (opening a new ticket). 

But interestingly, I copied the latest release map to my desktop (the one I made this
afternoon from the rawtherapee.test map), renamed it to rt3a1, tar-gz'ed it and sent
it to another pc in my home (Ubuntu 9.10 32-bit, family machine, no dev stuff on it),
unpacked it there, doubleclicked rt and it worked like it should! Before (when I
started to publish precompiled alpha shots for Ubuntu) there were complaints about
a
missing glib2 library (or something like that). So there's definitely progress going
on! I also see now that the Prefs button has moved to the left and that the
fullscreen button/F11 works. Apparently there's so;ething wrong with my update system
(a bash alias), I'll check that soon.  

Regards, Paul. 

Reported by paul.matthijsse4 on 2010-04-26 20:07:49

[Beep6581]

Hello, found a new problem today while translating RT3a1 into Dutch. The original
(English) language file has changed recently. As a result the language patch of the
starter of this thread, Philippe, only works half. Example: the string 'File Browser'
can now be found around line 280 of the language file: MAIN_FRAME_FILEBROWSER;File
Browser, Before this was absent because hard-coded.
Philippe patched it this way: +MAIN_TAB_FILE_BROWSER;File Browser (and that worked
with rt-rev35). +MAIN_MSG_PLACES;Places doesn't work anymore, it's called now
MAIN_FRAME_PLACES;Places

Regards, Paul.

Reported by paul.matthijsse4 on 2010-04-27 10:22:54

[Beep6581]

Yeah, a little while ago I had sorted all of the language files; I debated whether or
not to do this, as it would make life difficult when applying patches, but it made
things easier to compare between languages; 6 of one, half dozen of the other.

The other problem is that there were two patches which changed the same hard coded
items, but called them different things.  I applied them both, but manually tried to
merge, and arbitrarily decided which to use if there was a conflict.  I think I did
it right, but may have missed some terms; if you find these, please open a ticket and
let me know.

Cheers

Reported by wyatt.olson on 2010-04-27 14:13:20

[Beep6581]

Hello, working on the Dutch translation, but there are some hard coded strings left
(ie. not in the language file). Btw. the line numbers here under may have changed a
bit since the beginning of March. 

rtgui/zoompanel.cc, lines 77+:
zoomIn->set_tooltip_text ("Zoom In");
zoomOut->set_tooltip_text ("Zoom Out");
zoom11->set_tooltip_text ("Zoom to 100%");
zoomFit->set_tooltip_text ("Fit to screen");
newCrop->set_tooltip_text ("Add new crop window");

rtgui/filepanel.cc:
84: Gtk::Label* devLab = new Gtk::Label ("Develop");
86: Gtk::Label* filtLab = new Gtk::Label ("Filter");
88: Gtk::Label* tagLab = new Gtk::Label ("Tagging");

rtgui/navigator.cc:
23: set_label ("Navigator");
55: position->set_text ("x = n/a, y = n/a");
56: R->set_text ("R = n/a");
57: G->set_text ("G = n/a");
58: B->set_text ("B = n/a");
59: H->set_text ("H = n/a");
60: S->set_text ("S = n/a");
61: V->set_text ("V = n/a");

rtgui/preferences.cc:
78: nb->append_page (*getBatchProcPanel(),      "Batch Processing");
93: Gtk::Frame* behFrame = Gtk::manage (new Gtk::Frame ("Behavior"));
103: behTreeView->append_column ("Property", behavColumns.label); 
104: behTreeView->append_column_editable ("ADD", behavColumns.badd); 
105: behTreeView->append_column_editable ("SET", behavColumns.bset); 
502: edFileNames = new Gtk::CheckButton ("Overlay filenames on thumbnails");

The Fullscreen button text has to be placed in the language file as well.
Idem for Resize - Method - Downscale (Better) and Downscale (Faster). 

Last note: in the File Browser window, there's a new blue icon in the upper bar
without tooltip (apparently: show icons at 100%). Tooltip must be transferred to
language file as well. 

Another last note about comment 21 in this thread: I think that only the line
"MAIN_MSG_PLACES;Places" (at the end) should be deleted, the rest is okay.

Cheers, Paul. 

Reported by paul.matthijsse4 on 2010-04-28 16:17:12

[Beep6581]

Thanks, just re-opened this ticket to reflect the newly found issues.  Do you have
time to make a patch for this against current mercurial head?  If not I can take a
stab at it, but it probably won't be for a little while.

Cheers

Reported by wyatt.olson on 2010-04-28 16:23:04

• Status changed: Started

[Beep6581]

Hello,

I am ready to redo the suppression of hard coded word and submit the patch within
this week.

Cheers

Reported by google@hupe.me on 2010-04-28 19:36:17

[Beep6581]

Beautiful, thanks!  As earlier posts state, many of these terms are now fixed, just
go off of the current Mercurial head and things should be fine.

Cheers

Reported by wyatt.olson on 2010-04-28 19:38:46

[Beep6581]

Some more:

rtgui/resize.cc, line 129 (or 170?):
Downscale (Better) and Downscale (Faster)

rtgui/curveeditor.cc, line 28+:
Gtk::Label* tslab = Gtk::manage (new Gtk::Label ("Type:"));

curveType->append_text ("Linear");
curveType->append_text ("Parametric");
curveType->append_text ("Custom");

line 86+:
highlights = Gtk::manage (new Adjuster ("Highlights", -100, 100, 1, 0));
lights     = Gtk::manage (new Adjuster ("Lights", -100, 100, 1, 0));
darks      = Gtk::manage (new Adjuster ("Darks", -100, 100, 1, 0));
shadows    = Gtk::manage (new Adjuster ("Shadows", -100, 100, 1, 0));

line 364:
curveType->append_text ("(Unchanged)");

rtgui/rtwindow.cc, line 32:
Raw Therapee must be RawTherapee, without that space!

Reported by paul.matthijsse4 on 2010-04-29 09:14:48

[Beep6581]

About strings in resize.cc you mentioned: them must be harcoded, because them are not
used in the GUI, but used for saving into settings file. Strings for names of resize
algorithms which are shown in the GUI are alredy added to English (US) file:

TP_RESIZE_DOWNSCALEB;Downscale (Better)

TP_RESIZE_DOWNSCALEF;Downscale (Faster)

Strings for "Fullscreen" button are also already in English (US) file.

MAIN_BUTTON_FULLSCREEN;Fullscreen
MAIN_BUTTON_UNFULLSCREEN;Exit fullscreen

Reported by iliaworld@yandex.ru on 2010-04-29 20:14:23

[Beep6581]

Hello, yes you are right! Would be a good thing when new strings in the English (US)
file are automatically added to the other language files. This way it's easier for
translators to see what has to be done. 

Regards,
Paul. 

Reported by paul.matthijsse4 on 2010-04-30 06:37:24

[Beep6581]

Hi everyone,

I send you a patch which allows the removal of hard-coded words.
New items have been added for all the supported languages.
Hope this will help.

Cheers,

Phil

Reported by google@hupe.me on 2010-05-01 18:21:35

---

• Attachment: patch-suppression-hard-coded-words.diff

[Beep6581]

I applied the patch to head.  I had to merge some conflicts between this one and the
specific French translation by Hombre (Apr 29th); when there was a doubt, I assumed
Hombre's had a higher priority than this patch, since it was specific to French.  If
you see any changes which you feel are incorrect, please just submit another 'hg
export' patch against head and I can apply it.

So what is the status of this issue now?  As far as anyone knows, is it resolved, and
all hardcoded strings are now translated?  If so I can close the ticket.

Cheers

Reported by wyatt.olson on 2010-05-01 19:43:35

[Beep6581]

Hello,

Thank you for applying this patch.
We can close the ticket.
I will send a specific issue for the french translation.

Cheers,

Phil

Reported by google@hupe.me on 2010-05-02 08:45:49

[Beep6581]

Reported by wyatt.olson on 2010-05-02 15:33:33

• Status changed: Fixed

[Beep6581]

Hello, please reopen this ticket, as there are a couple of minor problems left.
Yesterday I translated the dutch file ('Nederlands') and see still some english
strings in the Dutch gui. These are:

* Exposure-> Tonecurve: Type: *Linear/Parametric/Custom* (*...* are in English),
although i did translate the string CURVEEDITOR_PARAMETRIC;Parametrisch. Same with
Luminance curve. 

* Tab Transform - Adjust size: *Downscale (better/faster)*. In the English (US) file
I see: TP_RESIZE_DOWNSCALEB;Downscale (Better), in the file Nederlands this string
is
not there. 

* Preferences, Image processing, Demosaic: Number of DCB iterations and Apply DCB
enhancment step (should be enhancEment) still in English, ie. not in the language
files because hard coded. 

Note1: Preference windows, tab batch processing: ADD. When translated, this field
shows max. 4 characters, I need some more! (add = voeg toe). 

Note2. When a raw is opened, the navigator window (upperleft) still shows x=n/a,
y=n/a. As with RGB and HSV, it should be translateable as well (to n/b in Dutch, or
German).

Note3. When raw is opened, the tooltip msg for the + sign under (next to zoom in/out
buttons) shows: Add new crop window. This should be: Open (new) detail window.
(ZOOMPANEL_NEWCROPWINDOW;Add new crop window)

Note4. In File Browser: blue icon above (next to trash) still has no tooltip.

Note5. The English (US) file has two same paragraphs, at the end. 
Starts with: 
EXIFFILTER_METADATAFILTER;Enable Metadata Filters
ends with:
ZOOMPANEL_100;(100%)
These are propagated to other language files as well. 

Note6. In File Browser, click on thumbnail, History on the right shows: Photo loaded
- batch processing. This is not correct. 

Cheers, Paul. 

Reported by paul.matthijsse4 on 2010-05-03 15:31:32

[Beep6581]

Reported by wyatt.olson on 2010-05-03 15:38:02

• Status changed: Started

[Beep6581]

Hi Paul,

You are rigth.
Do you plan to do the modifications?
Do you want me to do it? Feel free to ask me.

Cheers,

Phil

Reported by google@hupe.me on 2010-05-03 18:58:04

[Beep6581]

Hello Phil,

I certainly want to help to get these little things away, but with some I am not sure
how to do it. I even don't know how to patch the rt code (although I managed to patch
some sample code here on my machine :-). I think it is faster when you make the
patch(es), I'll dive in later to check if everything is really like it should be. 

(I'm not a C++ programmer, just an amateur photographer who knows a little bit about
programming and compiling. I'll be happy to help with the languages part, as I read
English, Dutch (native), French and German. A few hundred years ago I worked at
Borland Netherlands, testing multiple translations of a database called Paradox,
including Finnish :-)

Reported by paul.matthijsse4 on 2010-05-03 20:07:48

[Beep6581]

Hi Paul,

All the modifications you have suggested have been done except Note 6 (because I
don't se what is wrong).
Would you mind to check my modifications once the patch is applied?
Thank you in advance.

Cheers,

Phil

Reported by google@hupe.me on 2010-05-04 20:33:38

---

• Attachment: patch-suppression-hard-coded-words-v20100501.diff

[Beep6581]

Thank you for the patch, due to recent eye surgery I won't be able to apply this
patch for a few days. I apologize for the inconvenience.

Reported by wyatt.olson on 2010-05-05 01:39:00

[Beep6581]

Take care, patches can wait...

Reported by paul.matthijsse4 on 2010-05-05 10:11:39

[Beep6581]

Don't worry;
I hope you will be back soon with us;
Take care.

Cheers,

Phil

Reported by google@hupe.me on 2010-05-06 18:55:01

[Beep6581]

OK, this should be applied now.  As always, please verify that I didn't mess anything
up :-)  The patch applied cleanly with the exception of hunk #1 for the Francais
language file; not sure why it failed, but I manually applied that change and it
looks to be correct.

Cheers 

Reported by wyatt.olson on 2010-05-10 17:54:32

• Status changed: PatchSubmitted

[Beep6581]

Hello, nearly perfect! Two things though:

1. In the Dutch language files there are two lines missing:
PREFERENCES_DCBENHANCE;Apply DCB enhancement step
PREFERENCES_DCBITERATIONS;Number of DCB iterations

2. Preferences window, tab Batch processing, top of window:
Still not enough space/characters to translate ADD (Voeg toe in Dutch, now it shows
only Voeg)

When these two things are addressed, I'll attach a patch file (learned that today!),
as well as the new language file Nederlands (in case my first patch turns out to be
faulty...). 

Regards, Paul. 

Reported by paul.matthijsse4 on 2010-05-11 13:42:33

[Beep6581]

Addition: named DCB lines are also missing in the French language file, but are
present in the German one...

Reported by paul.matthijsse4 on 2010-05-11 13:56:11

[Beep6581]

Sounds great!  Check out the Wiki page I wrote on Mercurial to get the patches,
basically use 'hg export' after committing your changes and it will export a .diff
as
well as including your commit comments and user name, etc.

Reported by wyatt.olson on 2010-05-11 13:56:32

[Beep6581]

I'll have a look at your tutor in the coming days. Can I do a dry-run or something
before messing up things/rawtherapee/googlecode/world & beyond? 

Reported by paul.matthijsse4 on 2010-05-11 16:34:43

[Beep6581]

Yep, basically when you commit locally, it does not affect google code at all (you
would have to 'hg push', and that requires authorization).  When you create a patch
using 'hg export', and send it to me, I will try to apply it locally.  When that
happens, the end result is that my repository is in the same state as yours.  If all
went well, I then will push to head (i.e. Google code), so that all the other people
can update their repos to the same state.  If there were any problems with your
patch, it would either fail to apply (and I could back out of it), or if it is just
minor problems, I would just manually correct them.

Give it a shot and post the patch here, and I will take a shot at applying it. :-)

Cheers

Reported by wyatt.olson on 2010-05-11 16:39:24

[Beep6581]

Hi everyone,

Thanks for applying the patch.
That's nice you are now familiar with mercurial Paul.
We are waiting for you first patch ;)

Cheers,

Philippe

Reported by google@hupe.me on 2010-05-11 18:56:10

[Beep6581]

Hi,

Hard coded words were still remaining in the histogram panel.
I propose the following patch.

Cheers,

Phil

Reported by google@hupe.me on 2010-05-11 19:29:40

---

• Attachment: supp-hard-coded-words-11052010.diff

[Beep6581]

Committed.  Thanks!  (A note: Mercurial, at least on my system, does not like the
accented 'e' in your last name; it gives the error as follows:

[code]
Quark:rawtherapee wyatt$ hg import ~/supp-hard-coded-words-11052010.diff 
applying /Users/wyatt/supp-hard-coded-words-11052010.diff
transaction abort!
rollback completed
abort: decoding near 'ilippe Hupé <rawthe': 'ascii' codec can't decode byte 0xc3 in
position 12: ordinal not in range(128)!
[/code]

I have just been changing it in the patches to 'e' (without the accent), it may be
better to just change this in your mercurial config though.  I know, this is the 21st
century, and Unicode should be ubiquitous, but what can you do :-P

Cheers

Reported by wyatt.olson on 2010-05-11 22:33:55

[Beep6581]

Philippe Hupé, hereby your name is downgraded to 19th century P. Hupe, aka phupe! :)
Good that you found these lasting hard coded things, just tonight I was thinking as
well to check the other languages by doing a grep on them, but you were faster!
Thanks for your work anyway! 

Reported by paul.matthijsse4 on 2010-05-11 23:39:21