Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.88k stars 323 forks source link

Should Haze Removal's depth map be visible only in the preview? #4910

Open TooWaBoo opened 6 years ago

TooWaBoo commented 6 years ago

@agriggio If "Show Depth Map" is checked. Navigator, Thumbnail, Histogram and the saved jpg shows the "Depth Map". Shouldn't it only affect the preview?

Edit: Changing sliders doesn't change the thumbnail. You have to do another action to get the correct thumbnail.

agriggio commented 6 years ago

If "Show Depth Map" is checked. Navigator, Thumbnail, Histogram and the saved jpg shows the "Depth Map". Shouldn't it only affect the preview?

I don't know. A similar thing happens with wavelet "show only one level" or retinex "show mask". There was a request about being able to export the depth map, and this is the simplest way. But I suppose that you can argue that it should only affect the preview. What do other people think? It's easy to change if needed.

Edit: Changing sliders doesn't change the thumbnail. You have to do another action to get the correct thumbnail.

Confirmed. Should work now.

TooWaBoo commented 6 years ago

If there is a reason to export the "Depth Map" it's OK for me

Thanatomanic commented 6 years ago

But I suppose that you can argue that it should only affect the preview.

@agriggio I'm not sure if it's relatively simple to show the histogram for the actual image, but output something else. That could give trouble with reading out colors with the pipette for example. But if it is, that would make much more sense than showing in the histogram that my image is mostly yellow.

agriggio commented 6 years ago

@Thanatomanic that's a different thing, which is probably way trickier to implement with the current architecture

agriggio commented 5 years ago

if the consensus is to change the behaviour, probably the same should be applied to other places, e.g. wavelet levels, pixelshift motion masks, lab regions show mask, retinex.

heckflosse commented 5 years ago

I vote for the current behaviour.