search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.75k stars 313 forks source link

Rename color toning methods #5057

Open Beep6581 opened 5 years ago

Beep6581 commented 5 years ago

Our current color toning method names (0):

TP_COLORTONING_LAB;L*a*b* blending
TP_COLORTONING_RGBSLIDERS;RGB - Sliders
TP_COLORTONING_RGBCURVES;RGB - Curves
TP_COLORTONING_SPLITCOCO;Color Balance Shadows/Midtones/Highlights
TP_COLORTONING_SPLITLR;Saturation 2 colors
TP_COLORTONING_LABGRID;L*a*b* color correction grid
TP_COLORTONING_LABREGIONS;Color correction regions

I want to rename them in a consistent and meaningful scheme.

If we go by the documentation, the old methods are split into "blending" and "addition". Assuming this distinction benefits the user, the proposed style would be (1):

TP_COLORTONING_LAB;Blending - L*a*b* Curves
TP_COLORTONING_RGBSLIDERS;Blending - RGB Sliders
TP_COLORTONING_RGBCURVES;Blending - RGB Curves
TP_COLORTONING_SPLITCOCO;Addition - RGB
TP_COLORTONING_SPLITLR;Addition - RBG Sliders
TP_COLORTONING_LABGRID;Grid - Shadows/Highlights
TP_COLORTONING_LABREGIONS;Grid - Masks

Assuming the user doesn't benefit from that distinction, we could name them by what they expose (2):

TP_COLORTONING_LAB;Color/Opacity Curves - L*a*b*
TP_COLORTONING_RGBSLIDERS;Shadows/Highlights Color/Saturation Sliders - L*a*b*
TP_COLORTONING_RGBCURVES;Color/Opacity Curves - RGB
TP_COLORTONING_SPLITCOCO;Shadows/Midtones/Highlights RGB Sliders
TP_COLORTONING_SPLITLR;Shadows/Highlights Color/Saturation Sliders - RGB
TP_COLORTONING_LABGRID;Grid - Shadows/Highlights
TP_COLORTONING_LABREGIONS;Grid - Masks

which is a bit long, so shortened (3)

TP_COLORTONING_LAB;Color/Opacity - L*a*b*
TP_COLORTONING_RGBSLIDERS;Shadows/Highlights - L*a*b*
TP_COLORTONING_RGBCURVES;Color/Opacity - RGB
TP_COLORTONING_SPLITCOCO;Shadows/Midtones/Highlights - RGB
TP_COLORTONING_SPLITLR;Shadows/Highlights - RGB
TP_COLORTONING_LABGRID;Grid - Shadows/Highlights
TP_COLORTONING_LABREGIONS;Grid - Masks

which sorted would be (3-sorted):

TP_COLORTONING_LAB;Color/Opacity - L*a*b*
TP_COLORTONING_RGBCURVES;Color/Opacity - RGB
TP_COLORTONING_RGBSLIDERS;Shadows/Highlights - L*a*b*
TP_COLORTONING_SPLITLR;Shadows/Highlights - RGB
TP_COLORTONING_SPLITCOCO;Shadows/Midtones/Highlights - RGB
TP_COLORTONING_LABGRID;Grid - Shadows/Highlights
TP_COLORTONING_LABREGIONS;Grid - Masks

Thoughts?

Thanatomanic commented 5 years ago

My thoughts are really scattered on this. In my view this tool has way too many modes. I dare to admit that only after @agriggio implemented his masked regions tool, I discovered that the Color toning module was useful for me at all. Since the default mode and setting were a wacky two-tone blue-orange, I had previously always thought this was this module was just an 'artistic' filter, and I had always shunned it. But now I know some of the modes are actually useful, and the Lab regions is spectacularly powerful! So at least it's a very good thing that's now the default (right? although it's not the first item in the dropdown).

As for the naming of the other modes, maybe I don't care enough, because I personally see very little value in keeping them around 😉 That being said, I think I can live with your final suggestion.