Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.81k stars 318 forks source link

HaldCLUT filenames incomplete in combobox #5071

Open Beep6581 opened 5 years ago

Beep6581 commented 5 years ago

RawTherapee (5.5-rc1) sometimes discards the last word or a part of a word after a hyphen from the HaldCLUT filename.

Add these HaldCLUTs to your HaldCLUT folder, restart RT and see the Film Simulation combobox: https://filebin.net/zpfi08iagwfkwiwe

Filenames:

Hald_CLUT_Identity_12 RTv2_sRGB input-none.tif
Hald_CLUT_Identity_12 RTv2_sRGB working-sRGB.tif
Hald_CLUT_Identity_12 RTv2_sRGB.tif
Hald_CLUT_Identity_12 RTv2_Wide.tif
Hald_CLUT_Identity_12 RTv4_sRGB.tif
Hald_CLUT_Identity_12 RTv4_Wide.tif

RT shows: screenshot_20181207_085416

agriggio commented 5 years ago

This is sort of expected. If the CLUT name ends with a working profile name, that is stripped off, and used as the colour space for applying the CLUT. The logic is more or less as follows. If you have a CLUT called MyClut_ProPhoto, it will show up as MyClut_, and the image will be converted to ProPhoto when applying the clut. Something like this:

I don't know why sRGB gamma is always applied, but, alas, that's what happens (if I understand the code correctly).

Beep6581 commented 5 years ago

I had no idea.

Ref: https://github.com/Beep6581/RawTherapee/blob/dev/rtengine/clutstore.cc#L268

Hmm, ok, but it would be better if it still showed the name of the profile - why wouldn't anyone want to see that?

The identity HaldCLUT supplied by us, and the one generated using imagemagick according to our recipe, will end up using sRGB chromaticity primaries. I hadn't examined the gamma, but maybe RT assumes sRGB gamma for the same reason?