Unicode patch for contrast (by detail levels) sliders

[Beep6581]

Originally reported on Google Code with ID 547

In windows builds there is something wrong with unicode chars in the captions of the
sliders in the section "Detail::Contrast by detail levels". On linux builds the captions
are OK. You can see that on the screenshot.

Therefore I rewrote parts of the code which is responsible for the captions. The code
compiles and the behaviour on Ubuntu is as before.

I would like to know if my patch fixes the problem for windows builds, but I'm not
able to compile RT for windows. Could anyone test my patch with a windows build? -
If it fixes the problem then I would create a similar patch for branch_3.0.

http://i.imgur.com/9XZMU.png

Reported by maweso on 2011-02-22 12:07:23

---

• Attachment: patch.diff

[Beep6581]

Hello and thanks for your patch! I compiled it for default on Win (7 x64) using Swedish
locale in RT. It worked perfectly! 
Thanks again,
Johan

Reported by johan.andersson@sodra.com on 2011-02-27 10:42:32

[Beep6581]

@Johan:

Have you tried my patch with unicode characters?

If a look into the Swedish language file I will see:

TP_DIRPYREQUALIZER_LUMACOARSEST;Grovast
TP_DIRPYREQUALIZER_LUMAFINEST;Finaste

Both strings do not contain any unicode character. Have you replaced (for your tests)
one of these strings by something which contains real unicode characters (ö, ä, ü,
...), e.g. "TP_DIRPYREQUALIZER_LUMACOARSEST;Tröskelvärde"?

Reported by maweso on 2011-02-27 11:23:22

[Beep6581]

Ah, sorry, forgot to mention that I changed the word "Grovast" to the more correct translation
"Grövst". It was correctly handled by your patch. (In fact I changed the translation
a while back from "Grövsta" to "Grovaste" just as a work around...)

Regards,
Johan

Reported by johan.andersson@sodra.com on 2011-02-27 14:21:08

[Beep6581]

Sorry for being late, MaWe. Works fine here in my Windows, too. I committed it for You.
Thanks for Your contribution!
Olli

Reported by oduis@hotmail.com on 2011-02-27 16:30:27

• Status changed: Fixed

[Beep6581]

@Johan: Thank you very much for your helpful comments.

@Olli:
You was a little bit to quick. This issue also applies to the sliders in equalizer.cc.
Therefore below there is an additional patch for the default branch which fixes the
similar problem in equalizer.cc. And there is a second patch especially for branch_3.0
which combines both bugfixes (dirpyrequalizer.cc, equalizer.cc).

Reported by maweso on 2011-02-27 17:36:50

---

• Attachment: default.patch
• _Attachment: branch_3.0.patch_

[Beep6581]

> You was a little bit to quick. 
I did not realize from the comments that there was a problem with the patch, just with
the language files.

So give me a sign if you think it's ripe. Usually we let a patch sit there for a day
to see if there are negative testings.

Reported by oduis@hotmail.com on 2011-02-27 18:54:22

• Status changed: PatchSubmitted

[Beep6581]

There is not really a problem. In dirpyrequalizer.cc and equalizer.cc nearly the same
code is used, so the bug appears in both source files. My first patch only fixed the
bug in dirpyrequalizer.cc but not in equalizer.cc. You have the choice:

1. Submit patch.diff AND default.patch into the repository. (Patch.diff fixes the bug
in indirpyrequalizer.cc; default.patch fixes the bug in equalizer.cc)

OR

2. Submit branch_3.0.patch into the repository. (This patch fixes the bug in BOTH,
dirpyrequalizer.cc AND equalizer.cc.)

Sorry for the confusion.

Reported by maweso on 2011-02-27 19:10:36

[Beep6581]

Olli, you have already committed patch.diff to default branch. That's OK, so dirpyrequalizer.cc
is fixed. Now additionally commit default.patch to the default branch; that will fix
equalizer.cc, too.

Reported by maweso on 2011-02-27 20:21:19

[Beep6581]

Ok MaWe, checked in to DEFAULT.
Is there any dev around on BRANCH3 who can check and commit the other patch?
Would save some options-backup-full-recompile-test-hassle...

Reported by oduis@hotmail.com on 2011-02-27 21:02:05

[Beep6581]

Reported by entertheyoni on 2012-04-23 20:43:53

• Status changed: Fixed