Blue square artifact when using IGV demosaicing

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program

https://rawtherapee.com

GNU General Public License v3.0

2.88k stars 323 forks source link

Blue square artifact when using IGV demosaicing #5516

Open gnafuthegreat opened 5 years ago

gnafuthegreat commented 5 years ago

Found using RawTherapee 5.7, official Windows build, Windows 10. I can also test on Fedora, but I haven't tried it there yet.

I see the following blue square artifact when selecting the IGV demosaicing method on a raw file with some blown out sky:

https://themayhaks.com/~gideon/rt-igv-artifact/P1000033-igv-crop.jpg

When choosing LMMSE or any other demosaicing method, the artifact doesn't appear:

https://themayhaks.com/~gideon/rt-igv-artifact/P1000033-lmmse-crop.jpg

I didn't change any other settings aside from the demosaicing method, so it should reproduce just by changing "Method" to "IGV". Here's the original raw file:

https://themayhaks.com/~gideon/rt-igv-artifact/P1000033.RW2

I don't know if this might be at all related to the older #1755. Different artifacts, but still blue.

heckflosse commented 5 years ago

@gnafuthegreat Can not reproduce using latest dev build.

gnafuthegreat commented 5 years ago

@heckflosse Thanks for checking! I'm happy with that answer if someone wants to close this issue. Not sure if anyone wants to verify what would've fixed it, though.

heckflosse commented 5 years ago

I can reproduce in 5.7 but not in current dev => closing

Beep6581 commented 5 years ago

Unfortunately I can still reproduce:

Version: 5.7-212-ga2d5ef356
Branch: dev
Commit: a2d5ef356
Commit date: 2019-11-06
Compiler: cc 8.2.0
Processor: Intel(R)\ Core(TM)\ m3-6Y30\ CPU\ @\ 0.90GHz
System: Linux
Bit depth: 64 bits
Gtkmm: V3.24.1
Lensfun: V0.3.2.0
Build type: release
Build flags:  -std=c++11 -march=native -Werror=unused-label -Werror=delete-incomplete -Wall -Wuninitialized -Wcast-qual -Wno-deprecated-declarations -Wno-unused-result -fopenmp -Werror=unknown-pragmas -O3 -DNDEBUG -ftree-vectorize
Link flags:  -march=native
OpenMP support: ON
MMAP support: ON

Delete PP3 if any exists.
Open file using default profile (Auto-Matched Curve - ISO Low)
Zoom to 100%.
Switch the demosaicing method to IGV.

screenshot_20191106_212343

heckflosse commented 5 years ago

@Beep6581 still can not reproduce on Win7

heckflosse commented 5 years ago

@Beep6581 Now I can...

Beep6581 commented 5 years ago

I tried to eliminate as many tools as possible, and found this fun combination: screenshot_20191106_213253

P1000033.jpg.out.pp3.txt

gnafuthegreat commented 5 years ago

@Beep6581 Wow, that looks like it could be a Fatboy Slim album cover!

heckflosse commented 5 years ago

I started work on this issue...

heckflosse commented 5 years ago

This is caused by using Avoid color shift in raw CA-Correction. Looking how to fix it...

Edit: To be more precise, it seems there are NaN values generated by some predemosaic tools and the igv-demosaic isn't robust against such NaN values.

nquantum commented 3 years ago

I still get yellow artifact from igv although noise is notice less than lmmse. Unfortunately artifact let me no choice to choose immse instead. Uncheck auto-correction, avoid color shift in Chromatic Aberration Correction won't help also. This is link of raw file: https://drive.google.com/file/d/1u00yg2-2ljOzFcCrdfBt3R_b58MdyOSc/view?usp=sharing

heckflosse commented 3 years ago

Uncheck auto-correction, avoid color shift in Chromatic Aberration Correction won't help also.

With auto-ca-correction unchecked it works fine here grafik

nquantum commented 3 years ago

Thank you for reply. However mine is not work like that. My system is windows10 64bit. Rawtherapee 5.8 download from rawtherapee web. This is picture before :

nquantum commented 3 years ago

And this is after :

nquantum commented 3 years ago

Anything?

Thanatomanic commented 3 years ago

@nquantum I can confirm your issue in RT 5.8. However, in the current development build of RT this issue does not exist anymore. If this is a critical issue for you, please consider using a nightly build: https://github.com/Beep6581/RawTherapee/releases/tag/nightly take the RawTherapee_dev_5.8 file. If you do not want to use a nightly build, please use the Raw White Points module and set it to 0.98.

nquantum commented 3 years ago

@Thanatomanic thank you. Happy to know that the issue already solve in development. Will wait until update. Meantime I will use LMMSE for some image that have this issue. Now you mention about Raw white point. Is that fix in build is something to adjust it value? That module is there for fix this kind of issue. I've read the link but not quite sure what it does? Anyway will try it. Does it reduce quality of image some how?