Regression: NIKON D5100 14-bit uncompressed raw files open black - Corrupt data near ...

[drvanger]

Nikon NEF file made with Nikon D5100 open as if they were completely black. In the file browser they are displayed correctly, but after opening a file in the editor by enter, the image becomes black. After that, they display as black rectangles also in the file browser. This happens only after the update to version 5.8. Version 5.7 and before worked correctly with the same raw files. As far as I can determine, this happens to all of my NEF files (several of which were edited with previous versions of Rawtherapee). I attached screenshots and uploaded a sample NEF file with an autogenerated pp3 file to: here After opening the file for editing, the following error message appears in the terminal:

/home/duri/Képek/2019_tel/rtbug/new/newest/DSC_9677.NEF: Corrupt data near 0x20879a0
/home/duri/Képek/2019_tel/rtbug/new/newest/DSC_9677.NEF: Corrupt data near 0x20879a0
/home/duri/Képek/2019_tel/rtbug/new/newest/DSC_9677.NEF: Corrupt data near 0x20879a0 

I'm using linux (Manjaro, kernel 5.4.18-1 but I could reproduce it with openSUSE 15.0 (linux 4.12.14)), and tried to use the official packages, as well as compiling Rawtherapee 5.8 from source.

[Beep6581]

Tested using other NIKON D5100 raw files (from RPU). Confirmed that compressed (lossless and lossy type 2) open correctly in 5.8-47-g12b1d8f76, while 14-bit uncompressed open black.

[Beep6581]

Confirmed that 5.7 opened all three types correctly.

[heckflosse]

Caused by https://github.com/Beep6581/RawTherapee/commit/bd6088837c99b95f9a9c53fdd5ff4990f1c550c0

[heckflosse]

Last row of this files contains garbage

I can fix that by reducing height by one or by two for this files. I prefer reducing height by two to get an even height.