search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.89k stars 323 forks source link

Question about a condition in ipwavelet.cc #5780

Open heckflosse opened 4 years ago

heckflosse commented 4 years ago

@Desmis Jacques, the following condition is always false https://github.com/Beep6581/RawTherapee/blob/dev/rtengine/ipwavelet.cc#L1347

because here https://github.com/Beep6581/RawTherapee/blob/dev/rtengine/ipwavelet.cc#L1272 !hhutili is checked and the above case is in the else case if this check.

Can you please have a look. Maybe that's a bug. If it's not a bug, we could simply remove line 1347 to 1351

Desmis commented 4 years ago

@heckflosse Yes or no a bug ? good metaphysical question :)

But you are true : lines between 1347 - 1351 seems to be always false

You can suppress, where should i do it ?

Thank you

Jacques

heckflosse commented 4 years ago

@Desmis I will do that in dev