Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.8k stars 316 forks source link

locallab - exposure: Tools won't work as long as "Exposure compensation" is set to something different than 0.00 #5819

Open ff2000 opened 4 years ago

ff2000 commented 4 years ago

I often just want to locally pull up the shadows. So I open the "Exposure" module, expand "Exposure tools" and pull up the "Shadows" slider. And nothing changes. I need to first dial in some value !=0.00 in the exposure compensation slider.

IMO the "Exposure" tools should all work regardless of the position of the "Exposure compensation" slider.

Desmis commented 4 years ago

@ff2000 I push a commit 59998a25 which fixe this behavior

jacques

ff2000 commented 4 years ago

Now it only works for shadows. If somebody wants to apply just highlight compression she/he has to chenge exposure compensation or (now) shadows.

The "shadows" was an example to supply a use case and something to try out. For the desired behaviour I added the last sentence: "IMO the "Exposure" tools should all work regardless of the position of the "Exposure compensation" slider." But perhaps that's not possible...

Desmis commented 4 years ago

Ok, I will open a new branch "localtest" where I hope you can find what you want ... Let me some times..

jacques

Desmis commented 4 years ago

@ff2000 You can use the branch "localtest" with 2 features

I open a Pull Request.... But why do you closed this issue ?

Jacques

Desmis commented 4 years ago

I made anothers changes

ff2000 commented 4 years ago

Thank you, changes in localtest look good. Closing was unintentional, so I'll reopen.