search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.69k stars 307 forks source link

Fujifilm X-T4 compressed RAW not decoded properly (black screen) #5845

Open nicholascw opened 4 years ago

nicholascw commented 4 years ago
RawTherapee version ``` // Archlinux Repository community/rawtherapee version 1:5.8-1 Version: 5.8 Branch: releases Commit: 9a9e0acbf Commit date: 2020-02-04 Compiler: cc 9.2.0 Processor: x86_64 System: Linux Bit depth: 64 bits Gtkmm: V3.24.2 Lensfun: V0.3.95.0 Build type: Release Build flags: -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -std=c++11 -Werror=unused-label -Werror=delete-incomplete -Wall -Wuninitialized -Wcast-qual -Wno-deprecated-declarations -Wno-unused-result -fopenmp -Werror=unknown-pragmas -O3 -DNDEBUG -ftree-vectorize Link flags: -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now OpenMP support: ON MMAP support: ON ```
System Version ``` Archlinux up-to-date Linux 5.7.7-arch1-1 #1 SMP PREEMPT Wed, 01 Jul 2020 14:53:16 +0000 x86_64 ```

Symptoms

Throughout test around different settings I found:

图片

Here (mega.nz-shared) are my RAW files (together with .pp3 metadata) packed with manifest.txt explaining what parameters each of the files are shooting with. I have tried to iterated through different settings to reproduce the bug. Also to be noted, these issues are persistent for all 1.0 / 1.01 / 1.02 firmware. Folder link is here for easy access and smaller the download size.

Contents of the ZIP archive ``` Filename Behavior Settings _DSF1443.RAF Normal Uncompressed / AdobeRGB / Single _DSF1444.RAF Normal Lossless / AdobeRGB / Single _DSF1445.RAF Black Compressed / AdobeRGB / Single DSCF1446.RAF Normal Uncompressed / sRGB / Single DSCF1448.RAF Normal Lossless / sRGB / Single DSCF1449.RAF Black Compressed / sRGB / Single DSCF1450.RAF Black Compressed / sRGB / HDR DSCF1451.RAF Normal Lossless / sRGB / HDR DSCF1452.RAF Normal Uncompressed / sRGB / HDR DSCF1453.RAF Cropped Uncompressed / sRGB / Continuous High DSCF1455.RAF Cropped Lossless / sRGB / Continuous High DSCF1456.RAF Black Compressed / sRGB / Continuous High ```

Let me know if any further tests are needed. I'll be willing to compile the master branch or attach a gdb debugger (though it seems to be a parsing error, should be easily reproduced rather than a build/machine specific), or more RAW files with different settings.

Thanatomanic commented 4 years ago

@nicholascw Thank you for this extensive and well-written report. We had a similar issue here regarding the strange crop, so I guess a fix should be relatively easy.

heckflosse commented 4 years ago

Iirc that's already fixed in 5.8 dev

Thanatomanic commented 4 years ago

@heckflosse @nicholascw Indeed, the crop was already fixed: https://github.com/Beep6581/RawTherapee/commit/ca605eece6cb799c0e349dd6303c55300ce7e69c

The compressed format doesn't work though.

heckflosse commented 4 years ago

The compressed format doesn't work though.

Confirmed. I will have a look if the compressed format works in ART. If it does, we may borrow some code.

nicholascw commented 4 years ago

@Thanatomanic Thanks for the quick update. I've confirmed that those two are fixed with the latest master branch and updated the issue to align with the title. Thanks again for nice work done by all of you!

nicholascw commented 4 years ago

Confirmed. I will have a look if the compressed format works in ART. If it does, we may borrow some code.

@heckflosse Oops, just tried on Archlinux with AUR pkgbuild script art-rawconverter-git, which pulls their master branch as build source, it seems not working properly as well.

RawTherapee: 图片

ART: 图片

ocroquette commented 3 years ago

I confirm that the "Continuous High" bug is fixed on master but not in 5.8.