search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.75k stars 313 forks source link

Lensfun, multiple profiles for a lens #5880

Open zstomp opened 4 years ago

zstomp commented 4 years ago

Lensfun has multiple profiles for some lenses (e. g. "Sigma 10-20mm f/4-5.6 EX DC HSM"). The profiles differ in crop factor, but RT seems to ignore it and always select the first one in the list in auto mode. Additionally, only the first profile is available in the drop box in manual mode.

Version: 5.8, Commit: 9a9e0acbf

Beep6581 commented 4 years ago

@zstomp please provide a sample raw file.

zstomp commented 4 years ago

@Beep6581 Sorry, I thought RAW wouldn't be necessary. Here you go: https://gofile.io/d/rUAiJD.

Beep6581 commented 4 years ago

@zstomp I get an error following the link:

Error: EPROTONOSUPPORT: protocol not supported, stat '/usr/src/app/index.html'

zstomp commented 4 years ago

@Beep6581 The link still works for me, hopefully that was a temporary problem. Please try direct link.

Beep6581 commented 4 years ago

The sample raw file uses a Sigma 10-20mm f/4-5.6 EX DC HSM. Lensfun (DB version 1, just updated) has two profiles for that, crop factors 1.53 and 1.62. The Canon EOS 1000D has a crop factor of 1.6.

The profiles differ in crop factor, but RT seems to ignore it

How have you established that?

zstomp commented 4 years ago

The sample raw file uses a Sigma 10-20mm f/4-5.6 EX DC HSM. Lensfun (DB version 1, just updated) has two profiles for that, crop factors 1.53 and 1.62. The Canon EOS 1000D has a crop factor of 1.6.

That's right.

The profiles differ in crop factor, but RT seems to ignore it

How have you established that?

The 1.6 profile has no distortion correction, but the one that is automatically or manually selected has it.

Lawrence37 commented 4 years ago

RT chooses the first lens from a list created by lensfun. The list is ordered such that the "best" match appears first. https://github.com/Beep6581/RawTherapee/blob/86471c88e0727c0e85766b6da8c088c836cc3105/rtengine/rtlensfun.cc#L481