Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.89k stars 323 forks source link

Replace deprecated GTK code #6103

Closed Thanatomanic closed 3 years ago

Thanatomanic commented 3 years ago

See https://developer.gnome.org/gtk3/stable/DeprecatedObjects.html. There are several instances where RT uses deprecated code. Before we step up to use GTK4 at some point in the future, it would be good to at least have no more legacy GTK3 code.

I'll soon create a branch to work on this.

Edit:

Thanatomanic commented 3 years ago

@heckflosse or @Floessie could you please advise me on how to fix the following: https://github.com/Beep6581/RawTherapee/blob/6454737d0ce48e8d1004018bdda347dd0526dd4c/rtgui/guiutils.h#L375-L383

The HScale class should be replaced by Scale, but it needs a way to ensure GTK_ORIENTATION_HORIZONTAL is used when instantiated. Normally you would do new Gtk::Scale(GKT_ORIENTATION_HORIZONTAL), but how would I approach that here?

Thanatomanic commented 3 years ago

Also, I managed to create this gem: image

Who needs a compact interface 👀

Thanatomanic commented 3 years ago

I think I have managed to replace everything so far. But I need to fix this. PR coming soon.

image