Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.91k stars 325 forks source link

Document Inspect #6115

Open Beep6581 opened 3 years ago

Beep6581 commented 3 years ago

I can't find documentation of the "Inspect" tab anywhere, nor keyboard shortcuts.

Thanatomanic commented 3 years ago

Very much agreed. It is very scattered and incomplete after the modifications by @rfranke

You can find some tiny mention if you Ctrl+F for 'inspect' on these RawPedia pages: http://rawpedia.rawtherapee.com/Getting_Started and http://rawpedia.rawtherapee.com/File_Browser

TechXavAL commented 3 years ago

Indeed.

But as I think has been mentioned elsewhere, its behavior is more or less random, as in:

I say this because I have experienced most of those different behaviors in a single RT session (no experience in the next/previous image, though).

From a documentation point of view, I think it's better those points get clarified before writing anything.

ff2000 commented 3 years ago

Probably we should discuss first how we really want to interact with "inspect". I think it would be enough to simply launch a maximized inspector window - with a title bar, not fullscreen. It stays open until you press ESC or close it with the icon. It makes the interaction and the code unnecessarily complicated when you have to manipulate the current window state and persistence with shortcuts. Also I just had an idea: Why not make it possible to generally inspect by pressing "f" (or whatever shortcut) and the option in the settings controls whether a new window pops up or you switch to the "inspect" tab? With the tab you have to move your mouse out of the file browser to select the tab, then move back to the image you want to inspect, hovering all the icons in between which introduces quite a big freeze as the intermediate images get loaded, too. Hovering an image and just pressing "f" to open the "inspect" tab would fix this.

Thanatomanic commented 3 years ago

There has been some discussion in https://github.com/Beep6581/RawTherapee/issues/5867 and the development took place here https://github.com/Beep6581/RawTherapee/pull/5593. In hindsight, I think this functionality should have had more discussion and testing before merge.

heckflosse commented 3 years ago

In hindsight, I think this functionality should have had more discussion and testing before merge.

I agree. My fault :(

Lawrence37 commented 3 years ago

From #5593 and #5872:

Two settings in preferences

Keyboard and mouse (separate window/full-screen)

Inspector tab behavior is unchanged.

Lawrence37 commented 3 years ago

Some minor behavior changes in #6222: