Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.94k stars 327 forks source link

Bundled profiles dropdown fails to load after one is used on an image. #6216

Open z0r0 opened 3 years ago

z0r0 commented 3 years ago

RawTherapee Version:

       Version: 5.8
        Branch: releases
        Commit: 9a9e0acbf
        Commit date: 2020-02-04
        Compiler: cc 9.2.0
        Processor: x86_64
        System: Linux
        Bit depth: 64 bits
        Gtkmm: V3.24.2
        Lensfun: V0.3.95.0
        Build type: Release
        Build flags: -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -std=c++11  -Werror=unused-label -Werror=delete-incomplete -Wall -Wuninitialized -Wcast-qual -Wno-deprecated-declarations -Wno-unused-result -fopenmp -Werror=unknown-pragmas -O3 -DNDEBUG -ftree-vectorize
        Link flags: -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
        OpenMP support: ON
        MMAP support: ON

OS Version:

➜   uname -a
Linux DellTop 5.11.13-arch1-1 #1 SMP PREEMPT Sat, 10 Apr 2021 20:47:14 +0000 x86_64 GNU/Linux

Explain the exact steps to reproduce the problem:

  1. Apply a bundled profile (or even the neutral profile)
  2. Attempt to add another profile, and the bundled profile list will fail to populate.

Screenshot

This occurs for all of my raw images to be processed, but I can upload a sample after being converted from adobe raw converter.

chaimav commented 3 years ago

I cannot confirm on RT 5.8 nor RT dev build 5.8-2847 for Windows 10. (But I did find different bug when testing that I will report)

jade-nl commented 3 years ago

I'm also not able to replicate this on any of the RTs I have installed.

Beep6581 commented 3 years ago

I cannot replicate in 5.8 nor in dev head 5.8-2847-g53bb6e41b either.

rsau commented 3 years ago

I am facing exactly same issue. It is not only in RawTherapee but also in ART 1.8.4.

No issues when I compile RawTherapee and ART but only in AppImage or prebuilt binary

OS: Ubuntu 20.04.2 LTS

Thanatomanic commented 3 years ago

I have just tested this on Kubuntu 20.04.2 LTS and cannot replicate, neither with 5.8 (installed by apt install rawtherapee) nor the self-compiled dev.

If two people report the same issue, there must be another factor at play. @z0r0 and @rsau do you have a single or multiple monitor setup? And do you use RT on the primary monitor or another?

rsau commented 3 years ago

Hi @Thanatomanic
I have dual monitor setup. Same behaviour on either monitor. I'll record screencast in a day or two.

Please try with AppImage as well. In the meantime I'll test Rawtherapee install with apt

Beep6581 commented 3 years ago

@z0r0 @rsau which version of GTK+ (not gtkmm) are you using in the affected build? I'm using GTK+ 3.24.22 and cannot reproduce.

jade-nl commented 3 years ago

I have a dual monitor setup and my system (Debian 10.9) comes with the buggy Gtk+ 3.24.5-1. I do see the buggy behaviour (not able to scroll through menus taller then then my screen).

I'm not able to reproduce on either monitor. Tried the latest appimage (5.8-2921-ge6fad4cb3) and the stable appimage (5.8)

I also noticed that @z0r0 used a rather old (Commit date: 2020-02-04) image. I reverted back to a commit just before and just after that date and build/installed. Not able to reproduce with either of those. I know it is not an appimage, but just in case.

rsau commented 3 years ago

I have libgtk-3-0:amd64 3.24.20-0ubuntu1

I tested by creating custom some profiles and they work without any issues but Bundled profiles not.

Same behaviour even if I install with apt

z0r0 commented 3 years ago

Hello all, thanks for the awesome feedback with this being my first bug with this project.

Looking back there's two questions:

  1. Monitor setup: regarding the monitor setup, this is when I'm using my laptop, and only the laptop's screen. If it's beneficial, i'll be able to attach this to a multi-monitor setup on the same screen and re-test. I'll do that tomorrow.
  2. GTK version. Right now, it looks like i'm running GTK3, and GTK4 Probably because I'm using gnome.
    ➜   pacman  -Si extra/gtk3
    Repository      : extra
    Name            : gtk3
    Version         : 1:3.24.29-1
    Description     : GObject-based multi-platform GUI toolkit
    Architecture    : x86_64
    URL             : https://www.gtk.org/
    Licenses        : LGPL
    Groups          : None
    Provides        : gtk3-print-backends  libgtk-3.so=0-64  libgdk-3.so=0-64  libgailutil-3.so=0-64

    AND

    ➜   pacman  -Si extra/gtk4
    Repository      : extra
    Name            : gtk4
    Version         : 1:4.2.0-5
    Description     : GObject-based multi-platform GUI toolkit
    Architecture    : x86_64
    URL             : https://www.gtk.org/
    Licenses        : LGPL
    Groups          : None
    Provides        : libgtk-4.so=1-64

As a follow up, I will test this on a multi-monitor setup tomorrow and follow up.

maricn commented 3 years ago

I'm having the same issue with almost all menus. If I use them (click on an item), that parent menu becomes unexpendable.

image

~ ❯ uname -a
Linux work-x1c-arch 5.14.11-arch1-1 #1 SMP PREEMPT Sun, 10 Oct 2021 00:48:26 +0000 x86_64 GNU/Linux

~ ❯ paru -Si rawtherapee
Repository      : community
Name            : rawtherapee
Version         : 1:5.8-2
Description     : A powerful cross-platform raw image processing program
Architecture    : x86_64
URL             : https://www.rawtherapee.com/
Licenses        : GPL3
Groups          : None
Provides        : None
[...]

~ ❯ paru -Si extra/gtk3
Repository      : extra
Name            : gtk3
Version         : 1:3.24.30+90+g20be04f7ac-1
Description     : GObject-based multi-platform GUI toolkit
Architecture    : x86_64
URL             : https://www.gtk.org/
Licenses        : LGPL
Groups          : None
Provides        : gtk3-print-backends  libgtk-3.so=0-64  libgdk-3.so=0-64
                  libgailutil-3.so=0-64
[...]

~ ❯ paru -Si extra/gtk4
Repository      : extra
Name            : gtk4
Version         : 1:4.4.1-1
Description     : GObject-based multi-platform GUI toolkit
Architecture    : x86_64
URL             : https://www.gtk.org/
Licenses        : LGPL
Groups          : None
Provides        : libgtk-4.so=1-64
[...]

I've tried and the same bug is happening both on multi-monitor and on laptop single-screen setups. I'm using swaywm (wayland), but that doesn't seem to be the case for other reporters of the bug.

Interesting thing to note is that it is just not visible, but if I use the keyboard to navigate inside the submenu and move the cursor up/down, and press enter, the selection will be made. So if you know exactly which item it was, you can navigate to it with keyboard. OR navigate to the first item in the submenu, and focus the select dropdown (without expanding it), and use up/down keys to see all the options.

These are pretty sad workarounds, so I'm looking forward to the fix. Thank you!