search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.69k stars 308 forks source link

Canon EF 70-300mm f/4-5.6 IS II USM reported as "Unknown 70-300" #6224

Closed Jacalz closed 3 years ago

Jacalz commented 3 years ago

Short description

I am having an issue with my Canon CR2 raw files from my "Canon EF 70-300mm f/4-5.6 IS II USM" being reported as "Unknown 70-300" from my Canon 5d Mark 2. All my other lenses work fine, so I decided to open this issue to try and get it fixed. It is quite annoying.

I thought that this was because exiv2 did not support it, but it looks like it actually does:

$ exiv2 -pt 70-300exiv2.jpg | grep -ai lens
Exif.CanonCs.LensType                        Short       1  Canon EF 70-300mm f/4-5.6 IS II USM
Exif.CanonCs.Lens                            Short       3  70.0 - 300.0 mm
Exif.Canon.LensModel                         Ascii      70  EF70-300mm f/4-5.6 IS II USM

I found https://github.com/Beep6581/RawTherapee/issues/5670 which seems related, but it looks to be specific to Sony cameras if I understood things correctly, so I figured it would be best to open a new issue. Sorry if I am creating a duplicate.

Steps to reproduce

  1. Open a CR2 image taken with the lens.
  2. Look at the information box.

Expected behavior

Should say "Canon EF 70-300mm f/4-5.6 IS II USM" instead of "Unknown 70-300". image

Additional information

The zip file contains a CR2 image that exhibits from this issue. _MG_7884.zip

rebio commented 3 years ago

Just a guess on my side, but I think it's related to #5691 ("Lens autodetect can't find Canon EF-M 18-55mm lens"). It's not RT but lensfun as far as I know. See also https://github.com/lensfun/lensfun and maybe drop the issue there

EDIT: After taking a look at #5363 ("Canon EOS RP should be supported, even without .CR3 format suport") I'm pretty sure it's lensfun

Jacalz commented 3 years ago

Lensfun does not contain corrections for this lens as far as I know. Can it really be causing this issue then?

rebio commented 3 years ago

Lensfun does not contain corrections for this lens as far as I know. Can it really be causing this issue then?

Not sure on this, but I think RT uses lensfun for extracting the lens name as well (would make some sense since it would need to pass on the data to lensfun to select the correct profile anyway. So why not use their naming directly?)

Jacalz commented 3 years ago

Good point. Will see if I can make some corrections for the lens and put it into lensfun.

Lawrence37 commented 3 years ago

As far as I know, RT does not get the lens name from Lensfun.

Thanatomanic commented 3 years ago

@Lawrence37 Correct. The issue @rebio filed with the lensfun team is moot. This has to do with the metadata extraction that RT does. Our rtexif module needs manual updates by cross-checking the lens and camera identifiers that exiv2 and ExifTool support. This is something we should definitely do before releasing 5.9 (or #5889 needs to be merged).

Beep6581 commented 3 years ago

I'll do it One Last Time© for 5.9, then its exiv2 mergy mergy time.

Beep6581 commented 3 years ago

No need to have this issue open.

Jacalz commented 3 years ago

Is there any plan on when 5.9 will release then?

Thanatomanic commented 3 years ago

If you look at the main Issue page, it is one of the two pinned issues: https://github.com/Beep6581/RawTherapee/issues/5632

Jacalz commented 3 years ago

Thanks 👍

doumeb commented 1 year ago

Hey I have the same problem with this Canon EF 70-300mm f/4-5.6 IS II USM And the other work fine with my canon 6D mark2 on darktable. 24-70 L F4 and 40 F2.8 I'm on the 4.0 of darktable and ubuntu 22.04