search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.91k stars 325 forks source link

Leic M8 DNGs not working in RT dev version 5.8-3095 #6498

Open Reiner1959 opened 2 years ago

Reiner1959 commented 2 years ago

Hi,

just discovered that my old Leica M8 DNGs not working anymore. Pictures look way overexposed. Standard RT 5.8 is still working, darktable as well.

best regards Reiner

Here is the link to the file https://filebin.net/0etmiu7dtibd0ni5

Here is the screenshot grafik

Reiner1959 commented 2 years ago

I have just read this thread: Leica M8 sample interpreted with wrong bit depth #6237

In the discussion i have read that removing the Leica M8 entry in camconst.json could fix the issue.

I commented out the Leica M8 entry in camconst.json and it seems to work now. The question is: Do we really need this entry, or must the fix be done somewhere else?

best regards Reiner

Lawrence37 commented 2 years ago

@Reiner1959 It turns out the fix (actually a workaround) for #6237 wasn't complete. I have removed the camconst entry from dev.

The DNGs report a bit depth of 8 and that causes the white level to be capped at 255. Maybe there should be an exception for these DNGs. https://github.com/Beep6581/RawTherapee/blob/9bde8f18dc3ae7a49445c354cb4ab2d2ce32a158/rtengine/dcraw.cc#L9092-L9099

There's also some suspicious code here. It doesn't seem to have any effect on the black and white levels except when the white level exceeds the bit depth. https://github.com/Beep6581/RawTherapee/blob/9bde8f18dc3ae7a49445c354cb4ab2d2ce32a158/rtengine/rawimage.cc#L1001-L1006