search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.8k stars 316 forks source link

AppImage: Icon resolution #6527

Closed rebio closed 1 year ago

rebio commented 2 years ago

Short description The resolution of the AppImage icon varies.

Steps to reproduce Can not be reproduced within the program

RT 3101, 3102, 3104

Expected behavior Icon looks the same every time

Additional information AppImage used on KDE neon

The displayed resolution of the logo was way more pixelated in the past (like 8 x 8px). Then it got way better as it is shown for 3101. Now it get's worse.

I don't care much about the logo resolution. If you are not Captain Care'a'lot either feel free to close the report. I wanted to mention it as soon as I noticed it to avoid the unanswerable question which commit the change was caused by.

Lawrence37 commented 2 years ago

This could be because of the desktop environment. I downloaded the 3101 AppImage and the icon is 32x32, the same as the one you show for 3102.

rebio commented 2 years ago

I tested this on other DEs as well:

All tested DEs except one only showed a generic AppImage icon and not the RT icon. The one that did show the icon was KDE neon with default KDE (neon-user-20220721-0952.iso). So exactly what I use. Neither Gnome nor Pantheon displayed the icons. The strange thing: Other distros with KDE did not either.

I ran all systems from a live USB. I wouldn't expect that to be any different but I don't know for sure.

rebio commented 2 years ago

A bug report at the KDE bugtracker was closed as this problem is caused by the AppImage: https://bugs.kde.org/show_bug.cgi?id=456970

Lawrence37 commented 2 years ago

So they use the .DirIcon. The AppImage build process uses linuxdeploy to automatically generate that file. Unless there is an argument for using a specific resolution, I will leave it up to linuxdeploy to choose.

rebio commented 2 years ago

I don't know if anybody has changed the code for this, but 3151-ge5007c77 has a higher resoluted icon again

RT icons

Thanatomanic commented 2 years ago

Thanks for the follow-up. So, the report is no longer valid?

rebio commented 2 years ago

Considering that the quality was changing in the past and switched through various resolutions I would wait until the next Automated build to really say more about this. If there was no change for a component regarding the building process or how the logo is handled I wouldn't expect that the random nature of this changed. Considering the pattern I observed, the chosen logo resolution seems to be somewhat random for each build. (3101 & 3151 = High resolution, 3102 = medium resolution, 3104 - 3140 = low resolution)

I noted it as soon as I observed it so it's easier to find the bug.

Beep6581 commented 2 years ago

RT 3101, 3102, 3104

Looks like RawTherapee has been attacking the whiskey cabinet again.

Beep6581 commented 1 year ago

Both 5.9 and dev AppImages appear fine now - closing as fixed.