search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.82k stars 319 forks source link

Accented characters: problem editing the current image in an external editor #6754

Open preuthier opened 1 year ago

preuthier commented 1 year ago

Accented characters: problem editing the current image in an external editor

Hello everyone !

I needed to use the export function of the edited image in order to open it in GIMP. It did not work.

It seems that the function of exporting the edited image to GIMP does not work when the path of the image contains characters outside the ASCII code (spaces and accented characters).

I specify that I work under Windows 11. Here are the characteristics of my version of RawTherapee:

Version: 5.9 Branch: 5.9 Commit: 9b8583988 Commit date: 2022-11-27 Compile: cc 12.2.0 Processor: generic x86 System: Windows Bit depth: 64 bit Gtkmm: V3.24.7 Lensfun: V0.3.3.0 Build type: release Build flags: -std=c++11 -ffp-contract=off -mtune=generic -Werror=unused-label -Werror=delete-incomplete -fno-math-errno -Wno-attributes -Wall -Wuninitialized -Wcast-qual -Wno-deprecated-declarations -Wno-unused-result -Wunused-macros -fopenmp -Werror=unknown-pragmas -O3 -DNDEBUG -ftree-vectorize Link flags: -mtune=generic OpenMP support: ON MMAP support: ON Build OS: MINGW64_NT-10.0-20348 3.3.6-341.x86_64 x86_64 Build date: Sun, 27 Nov 2022 18:38:56 +0000 UTC Build epoch: 1669574336 Build UUID: 9d19d210-c668-4aa2-8af6-2d527fd55d1c

I refer you to the discussion I opened on this subject on pixls.us. You will find screenshots and explanations of the problem encountered and the tests to try to identify the problem.

https://discuss.pixls.us/t/problem-editing-the-current-image-in-an-external-editor/36842

Please take a look and let me know what can be done to fix this problem.

Beautiful day !

Lawrence37 commented 1 year ago

With the development version, RawTherapee is able to successfully launch GIMP with an image path that includes a character with an accent mark, a space, and even an emoji. GIMP: image RawTherapee: image

Setting the application as a native command might lead to the issue you're seeing, but GIMP works well as a non-native command.

apostel338 commented 1 year ago

Edit...

Nvm. Tested with latest Win-dev build and in fact it works.

Lawrence37 commented 1 year ago

@apostel338 Is that with the native command option enabled? It look like the native command does not use Unicode and thus causes problems for characters outside the legacy Windows character set. The fix in ART changed the program launcher function to use the Unicode variant.

apostel338 commented 1 year ago

You are right, native command doesn't work.