Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.79k stars 316 forks source link

Windows build crash : file INSTALL cannot find "//AboutThisBuild.txt": No error. #6756

Closed gaaned92 closed 1 year ago

gaaned92 commented 1 year ago

Compilation environment W10 , MSYS2/UCRT64

Build procedure (

    cmake -G "MSYS Makefiles"  -DLENSFUNDBDIR=share/lensfun -DPROC_TARGET_NUMBER="10" -DPROC_FORCED_LABEL=$PROCNAME  -DPROC_TARGET_10_FLAGS="$PROC" -DCACHE_NAME_SUFFIX=$CACHE  -DCMAKE_BUILD_TYPE=release -DCMAKE_INSTALL_PREFIX=$TEMP  -C../../$CNAT ../../rawtherapee 
 make -j8 install

During the install phase I get this error

[100%] Built target rth
Install the project...
-- Install configuration: "release"
-- Installing: D:/rawtherapee/rtsource/builds/temp/./AUTHORS.txt
-- Installing: D:/rawtherapee/rtsource/builds/temp/./LICENSE
CMake Error at cmake_install.cmake:49 (file):
  file INSTALL cannot find "//AboutThisBuild.txt": No error.

make: *** [Makefile:100: install] Error 1

AboutThisBuild.txt is just alongside cmake_install.cmake

Version: 5.9-151-g677aaf2ec
Branch: dev
Commit: 677aaf2ec
Commit date: 2023-04-29
Compiler: cc 12.2.0
Processor: Skylake
System: Windows
Bit depth: 64 bits
Gtkmm: V3.24.7
Lensfun: V0.3.95.0
Build type: release
Build flags:     -std=c++11 -ffp-contract=off -march=native -Werror=unused-label -Werror=delete-incomplete -fno-math-errno -Wno-attributes -Wall -Wuninitialized -Wcast-qual -Wno-deprecated-declarations -Wno-unused-result -Wunused-macros -fopenmp -Werror=unknown-pragmas  -DNDEBUG  -O3 -ftree-vectorize
Link flags:   -march=native  -s  -O3
OpenMP support: ON
MMAP support: ON
Build OS: MINGW64_NT-10.0-19045 3.4.6.x86_64 x86_64
Build date: Thu, 04 May 2023 09:42:30 +0000 UTC
Build epoch: 1683193350
Build UUID: 4adabc9a-7b4b-4151-9091-3a4039c326b0

Can you help me?

gaaned92 commented 1 year ago

for a reason I don't understand, when running CMAKE, the variable CMAKE_BINARY_DIR is empty. Thus cmake_install.cmake is wrongly generated.

gaaned92 commented 1 year ago

I made a hack, using CMAKE_CURRENT_BINARY_DIR instead of CMAKE_BINARY_DIR in CMakeLists.txt and it works. So I think it can be closed.