Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.84k stars 321 forks source link

PDAF lines filter not working with infrared conversion #6801

Open elite4jonny opened 1 year ago

elite4jonny commented 1 year ago

Hi,

I am not sure if this is a bug or a feature request,

I am using Sony A7Rii infrared converted camera, and I am experiencing black peppering horizontally across my images in a line like pattern. The dots appear worse in areas with high contrast near to the sky but can appear almost anywhere in the image. The effect is worst with the AMaZE Debayering. I have tried both the line noise and PDAF options but if anything they make it worse. Hot pixel and dead pixel suppression does not fix the issue. Changing the debayering to RCD removes a lot of the noise in this example, but in others it does not (sorry no example to hand).

Would it be possible to amend the way the options work to deal with this specific type of noise?

Screenshot 2023-07-26 at 13 02 52 Screenshot 2023-07-26 at 13 03 37 Screenshot 2023-07-26 at 13 04 42
Lawrence37 commented 1 year ago

PDAF line filter is supposed to be able to handle this and RawTherapee has the data on your camera's PDAF line locations. It just isn't good enough in this instance. Are you able to supply a sample raw file? You can use filebin.net to upload.

elite4jonny commented 1 year ago

RAW available here: https://filebin.net/btl4q7hlgakzdpw9

Just to note the lens is detected as ARAX MC 35 mm f/2.8 Tilt+Shift but it is actually the Sony 35mm f2.8 Issue happens on all lenses but just incase someone believed it to be tilt/shift related

Lawrence37 commented 1 year ago

This is both a bug and a feature request.

The bug is wrong PDAF line locations. In camconst.json, the PDAF lines pattern repeats every 420 pixels. However, the actual pattern is 840 pixels. It makes the filter ineffective for half the image.

The feature request is handling dead pixels. There are two ways of removing PDAF lines. The checkbox acts on the green pixels. The line noise filter is meant to fix small variations in brightness between rows and/or columns of pixels. In this image, the dark pixels come from dead blue pixels along PDAF rows. The dead pixel filter removes some the the bad pixels, but for some reason does not do a complete job.