Ctrl key not registering in film strip when not in focus

[seanptmaher]

Short description Selecting the currently edited photo via x does not actually select the photo, and therefore I cannot do anything with my keyboard. This is problematic because this drastically limits the amount of actions I can perform on the currently edited image via my keyboard.

Steps to reproduce

1. Open an image.
2. Do something to lose focus to the filmstrip - i.e. use a tool such as crop.
3. Press x to sync filmstrip. The currently edited photo becomes "selected".
4. Press Ctrl-Shift-2 to assign yellow label to currently edited photo.

Expected behavior Pressing x from editor behaves as if I had selected the image with my mouse that I am currently editing, and assigns the yellow label.

Actual behavior My filmstrip becomes empty. Not too sure why, but that's what happens.

Additional information RawTherapee version:

Version: 5.10
Branch: 5.10
Commit: 8adb5439d
Commit date: 2024-02-15
Compiler: cc 14.1.1
Processor: x86_64
System: Linux
Bit depth: 64 bits
Gtkmm: V3.24.9
Lensfun: V0.3.4.0
Build type: Release
Build flags: -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection         -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wp,-D_GLIBCXX_ASSERTIONS -g -ffile-prefix-map=/build/rawtherapee/src=/usr/src/debug/rawtherapee -flto=auto -std=c++11 -ffp-contract=off  -Werror=unused-label -Werror=delete-incomplete -fno-math-errno -Wno-attributes -Wall -Wuninitialized -Wcast-qual -Wno-deprecated-declarations -Wno-unused-result -Wunused-macros -fopenmp -Werror=unknown-pragmas -O3 -DNDEBUG -ftree-vectorize
Link flags: -Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now          -Wl,-z,pack-relative-relocs -flto=auto
OpenMP support: ON
MMAP support: ON
Build OS: 
Build date:  UTC
Build epoch: 
Build UUID: 

I believe it's the one from pacman.

My OS version is

Linux 6.9.3-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 31 May 2024 15:14:45 +0000 x86_64 GNU/Linux

[Lawrence37]

Cannot reproduce with self-built 5.10 on Linux. What are the exact steps for step 2?

[seanptmaher]

Here's a screencast.

https://fighet-parnet.github.io/2024/06/23/no-focus.mkv

It happens when I use crop, straighten tool, etc.

Just double click a photo, then via c + clickdrag, then all keybindings related to the filmstrip do not work, even after pressing x.

[Lawrence37]

Your video shows the x hotkey working as expected. The problem here is that the Ctrl modifier is not always registering. The x hotkey is irrelevant.