search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.89k stars 323 forks source link

Crop tool boundaries reset after crop turned off and change any other tools #7112

Open eugene-rom opened 4 months ago

eugene-rom commented 4 months ago

Steps to reproduce

  1. Turm on Crop tool and resize crop area
  2. Do some other image adjustments
  3. Turn off crop tool
  4. Do some other image adjustments
  5. Look at crop tool - crop area resetted to default

Expected behavior The crop tool contains the settings from my last adjustment.

Additional information Version of RawTherapee - 5.10 Version of your operating system - Ubuntu 20.04

Lawrence37 commented 4 months ago

This is the code that resets the crop region. https://github.com/Beep6581/RawTherapee/blob/61b382c1022c1690b5d9080ffe13673772dd9c7f/rtgui/crop.cc#L935-L942

It's probably used to set the width and height to the image dimensions when the image is first loaded. It needs to be smarter about when it does this.