search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.75k stars 313 forks source link

Dynmamic range and exposure spot crashes a particular edit #7121

Closed chaimav closed 1 month ago

chaimav commented 2 months ago

Using RawTherapee Dev 5.10-298 and editing the RAF image in this thread https://discuss.pixls.us/t/between-you-me-and-the-lamp-post/44334 This pp3 in this post https://discuss.pixls.us/t/between-you-me-and-the-lamp-post/44334/28?u=chaimav crashes RT. Spot is named appropriately

crash

Desmis commented 2 months ago

@chaimav

I confirm the bug, I'm looking, it might take a long time

Jacques

chaimav commented 2 months ago

If I get some free time, I plan on going through the rest of the PP3 and turning off things one at at time to see what the conflict is. The problem is, I need to re-open RT every time it crashes...

Desmis commented 2 months ago

I made a modification which should improve operation in the case where several Spots are used at the same time with "Dehaze" and "Dynamic Range & Exposure" > Exposure.

Exposure (in Selective Editing) has a capricious behavior, which meant that I added a Laplacian to it to reduce the fluctuations.

On many images, combining "Dehaze" and "Exposure DR" does not pose a problem. But with this image and numerous instances of "Dehaze" the Laplacian brings RGB values ​​out of bounds. Hence the crash.

I deactivated the Laplacian as soon as the user creates a Spot with Dehaze. In addition, I took advantage, given the complexity of the "Contrast attenuator" tool, to reserve it for Advanced mode. Which simplifies the interface in basic mode.

As a reminder, I do not recommend using "Exposure (SE)". There are many other tools that are generally more efficient for processing images. But of course you can use it https://rawpedia.rawtherapee.com/Local_Adjustments#Five_ways_to_change_the_exposure_and_lift_the_shadows

See also the latest advances regarding "Abstract Profile" (main) and "Selective Editing - Cam16 - Source Data Adjustements".

Branch drexpos

I created a PR with executables - drexpos https://github.com/Beep6581/RawTherapee/releases/tag/pre-dev-github-actions

chaimav commented 2 months ago

Thanks 👍. I have to admit that most of what you wrote went over my head (my understanding not your writing), but I am looking forward to testing the PR.

chaimav commented 2 months ago

I can confirm it no longer crashes.

Desmis commented 2 months ago

@chaimav

I modified the way of controlling the Laplacian. The previous change removed its use. Now I maintain the use but I control the RGB values. This seems much more relevant to me.

Can you check, the executables are being developed - drexpos https://github.com/Beep6581/RawTherapee/releases/tag/pre-dev-github-actions

Jacques

chaimav commented 2 months ago

I can confirm that the new version does not crash. The biggest behavioral difference between the two is the transition from the clouds to the sky. Look at the upper left corner. I can't say if one is better or not, as the parameters can probably tweaked on either to achieve the desired effect.

DSCF9835-319 New build

DSCF9835-311 Old build

Desmis commented 2 months ago

The only difference is: The new version (build) takes into account a Laplacian to ensure “smoother” transitions. This is what is in the basic "Dev" version, and which I removed to test if that was what was causing the problem.

The new version is like "dev" before, but now doesn't (hopefully) cause any more crashes.

Thank you for testing.

Jacques