Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.93k stars 326 forks source link

Preview anomaly when toggling a custom DCP tone curve on and off with Selective Editing tools activated #7147

Open waynesutton50 opened 4 months ago

waynesutton50 commented 4 months ago

Toggling the DCP Tone curve (Color Management > Input Profile) on and off when a Selective Editing tool has been added to a spot, progressively increases the brightness and contrast of the preview. The exported jpeg is normal. Steps to reproduce: -Open an image with a Neutral profile -Load a DCP profile into: Color Management > Input Profile > Custom -Activate Selective Editing, add any type of spot and activate for example the 'Color appearance' tool. -Return to the Input Profile menu and toggle the DCP tone curve on and off.

The image will become progressively brighter and the contrast will increase. Switching to the 'Camera standard' profile and back again will reset the preview. The anomaly occurs also in the 5.10 release.

Desmis commented 4 months ago

@waynesutton50

Thank you for reporting this old malfunction which dates back at least 5.9

In the PR #7111 , I made a modification to the "events" using DCP. I think this should work better.

They (events) are all at "ALLNORAW" except those in question here with "RGBCURVE | M_AUTOEXP" - the same as for Selective Editing. I made a change in refreshmap.cc ALLNORAW, //RGBCURVE | M_AUTOEXP, // EvDCPToneCurve, 21 july 2024 ALLNORAW, // EvDCPIlluminant, and ALLNORAW, //RGBCURVE | M_AUTOEXP, // EvDCPApplyLookTable, 21 july 2024 ALLNORAW, //RGBCURVE | M_AUTOEXP, // EvDCPApplyBaselineExposureOffset, 21 july 2024 ALLNORAW, // EvDCPApplyHueSatMap

The problem seems to be fixed - to verify.

Jacques