search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.82k stars 318 forks source link

Crash while computing minimum raw value of Canon Dual Pixel image #7213

Open Lawrence37 opened 2 weeks ago

Lawrence37 commented 2 weeks ago

Attempting to load a Canon Dual Pixel raw image results in a crash in dev.

This happens during the computation of the minimum raw value, which is used for raw de-haze. In this line, rawData is empty, so attempting to get the pixel value fails. https://github.com/Beep6581/RawTherapee/blob/00360a6dbb060587a300d809594c756069fda75b/rtengine/rawimagesource.cc#L8545

I used an image obtained from raw.pixls.us. The web page is down, and I can't upload the image because I don't remember the license for this particular file.

Weltherrscher commented 2 weeks ago

I could provide some examples. Give the sun some time to settle, then i shoot 2..3 pictures. //Edit: image No Crash on my end. Compiled the latest git.

Lawrence37 commented 1 week ago

After some more testing, this happens due to the handling of the selected sub-image number. Select SN mode for the sub-image, then reload the image in the editor. The crash does not happen if sub-image 1 or 2 is selected. I also tried with pixel shift images. They crash unless sub-image 1 is selected. Canon burst images work fine though.

Weltherrscher commented 1 week ago

Indeed, that way it crashes. That's a bad crash, after setting SN mode it is impossible to open DP-Raws again until the corresponding pp3 is deleted.

Lawrence37 commented 1 week ago

It's possible to use the batch edit tab to change the sub-image to 1 or 2. The image can then be opened in the editor without deleting the processing profile.