search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.88k stars 323 forks source link

Patch: fullscreen mode #73

Closed Beep6581 closed 9 years ago

Beep6581 commented 9 years ago

Originally reported on Google Code with ID 82

Added fullscreen mode which can be toggled by F11 and by button in lower
right corner of window.

Reported by iliaworld@yandex.ru on 2010-04-24 22:15:09

Beep6581 commented 9 years ago 
Added to head.

Reported by wyatt.olson on 2010-04-24 22:35:18

Beep6581 commented 9 years ago 
There is a bug: in fullscreen mode, then you doubleclick on the image and small
progress window appears, the gnome panels appear on top of rawtherapee window. So,
one need to exit fullscreen mode and enter again.

The simpliest solution could be: call raise function when progress window apeers.

Does enyone know the proper solution (probably this effect could appear not only
because of progress dialog, but other dialogs or smth completely different)

Reported by iliaworld@yandex.ru on 2010-04-24 22:39:07

Beep6581 commented 9 years ago 
FWIW it works fine for me (on OSX).  That being said, I find the popup 'demosaicing'
dialog to be Very Bad (TM) anyway; it would be better to have a dedicated status bar
area, probably on the bottom bar somewhere, where this sort of information is shown.

As for how people normally handle the fullscreen, I am not the one to ask for that
:-)

Cheers

Reported by wyatt.olson on 2010-04-24 22:46:27

Beep6581 commented 9 years ago 
This works for me. As the progress window is gone now I think the issue is fixed. Reopen
it if I missed something.

Reported by rinni@gmx.net on 2010-09-11 09:59:17

Beep6581 commented 9 years ago 
Sorry, still buggy for me.
1. Set Multitab layout in preferences
2. When in File Browser, press "Full screen"
3. Open any image

Image is opened, but fullscreen is gone away. The button still says "exit full screen".
Code looks correct on first glance, might be a GTK bug or something.
OS is Win7 x64

Same on other OSes?

Reported by oduis@hotmail.com on 2010-12-11 14:51:31

Beep6581 commented 9 years ago 
On Linux x64 it works. Might be Windows specific.

Reported by rinni@gmx.net on 2010-12-20 15:35:12

Beep6581 commented 9 years ago 
Please verify if this is fixed. Works fine in KDE4.

Reported by entertheyoni on 2011-06-05 08:01:33

Beep6581 commented 9 years ago 
Unfortunately it's not fixed. I already tried, but it seems to be a bug in GTK on Windows,
not a bug in RT.

Reported by oduis@hotmail.com on 2011-06-05 08:42:07

Beep6581 commented 9 years ago 
Issue 719 has been merged into this issue.

Reported by ffsup2@yahoo.it on 2011-06-07 20:40:03

Beep6581 commented 9 years ago 
Though it cannot fix the bug, this is a mitigation patch for DEFAULT. If you open an
image while in fullscreen mode, GTK exits fullscreen, but this make it fullscreen again.
So a flickering, but it works.
Unfortunately I could not find a workaround for the bug that GTK exits fullscreen if
you close an edit window. However, as soon as you open the next image from file browser
it will be fullscreen again.

Reported by oduis@hotmail.com on 2011-06-11 08:43:44

Beep6581 commented 9 years ago 
One day, no objections. Committed to DEFAULT.
I'll set this to "Won't fix", as it seems to be in GTK, not RT.

Reported by oduis@hotmail.com on 2011-06-12 10:19:25